You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Create tooling to update files in packaging.psm1, files.wxs, pwrshcommon.cpp automatically #6978
Whenever we reference new packages or existing packages add new assemblies, we go through a manual exercise to update source files. This should be automated and manually reviewed.
If the script find and report what lines we should remove or add why we can not edit the file automatically? It is not regeneration of the file from scratch.
Ilya (@iSazonov) basically, its just more work and it hasn't been done. I'm just listing the requirements for the work, which may not be obvious. We cannot just use the WiX toolset to generate the file and replace the existing file.
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
Activity
TravisEz13 commentedon Jun 5, 2018
Whenever files.wxs is regenerated, The following properties about existing components cannot change or patching will be completely broken:
This assumes we stick to the WiX recommendation of one file per component. If we don't, the rules become more complex.
iSazonov commentedon Jun 5, 2018
If the script find and report what lines we should remove or add why we can not edit the file automatically? It is not regeneration of the file from scratch.
TravisEz13 commentedon Jun 5, 2018
Ilya (@iSazonov) basically, its just more work and it hasn't been done. I'm just listing the requirements for the work, which may not be obvious. We cannot just use the WiX toolset to generate the file and replace the existing file.
iSazonov commentedon Jul 30, 2018
Travis Plunk (@TravisEz13) has already updated packaging.psm1 in #7272.
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 23, 2023
This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.