Skip to content

Running native interactive command-line app breaks history #571

Closed

Description

@vors

Please ignore this issue, if #495 is on it's way.
This issues is about src/Microsoft.PowerShell.Linux.Host/readline.cs

Repro

> top
# close top with Ctrl+C
# hit up arrow: get the last command

Expected

History works as normal, you get top as the last command

Actual

You got A as the last command

Activity

  1. added
    Issue-BugIssue has been identified as a bug in the product
    Usability(LEGACY) Helps filter issues that might be higher priority because they directly affect usability
    on Feb 21, 2016
  2. andyleejordan commented on Feb 21, 2016

    @andyleejordan
    Member

    I'm not certain #495 will solve this. By necessity it will reuse the readline implementation we have, because it's cross-platform and its existing one is Windows native specific.

  3. palladia commented on Feb 21, 2016

    @palladia
    Contributor

    #495 does not address this issue. This issue is same as #461.

  4. vors commented on Feb 21, 2016

    @vors
    CollaboratorAuthor

    Oh, my understanding was that "host ~ readline". So src/Microsoft.PowerShell.Linux.Host/readline.cs would stay? I then will start filling more usability bugs.

  5. andyleejordan commented on Feb 21, 2016

    @andyleejordan
    Member

    sergei (@vors) #495 is porting the Nano host to Linux. However, it will really only replace main.cs. Its UI implementation (the readline, ui, rawui, etc.) does not utilize System.Console; instead it P/Invokes to Windows native APIs. So even after porting the Nano host... most of it will be replaced with what we already have.

    I still have reservations about "porting" the Nano host, because ours is already (seemingly) close to feature-parity. I'd like to determine what managed code only features are available in the Nano that we don't have, before deciding which host to use as the primary one.

  6. andyleejordan commented on Feb 23, 2016

    @andyleejordan
    Member

    This is really similar to #484 as well.

  7. andyleejordan commented on Mar 1, 2016

    @andyleejordan
    Member

    This has been fixed upstream in dotnet/corefx#6488. Waiting to integrate changes.

  8. added
    Issue-BugIssue has been identified as a bug in the product
    and removed
    Issue-BugIssue has been identified as a bug in the product
    on Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Issue-BugIssue has been identified as a bug in the productUsability(LEGACY) Helps filter issues that might be higher priority because they directly affect usability

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions