Get-EnvironmentInformation does not properly check for CoreCLR

The following code incorrectly reports that I am using CoreCLR on Windows PowerShell 5.1

Lines 100 to 117 in 7dce411

    
           # Use the .NET Core APIs to determine the current platform. 
        
           # If a runtime exception is thrown, we are on Windows PowerShell, not PowerShell Core, 
        
           # because System.Runtime.InteropServices.RuntimeInformation 
        
           # and System.Runtime.InteropServices.OSPlatform do not exist in Windows PowerShell. 
        
           try { 
        
               $Runtime = [System.Runtime.InteropServices.RuntimeInformation] 
        
               $OSPlatform = [System.Runtime.InteropServices.OSPlatform] 
        
               $environment += @{'IsCoreCLR' = $true} 
        
               $environment += @{'IsLinux' = $Runtime::IsOSPlatform($OSPlatform::Linux)} 
        
               $environment += @{'IsMacOS' = $Runtime::IsOSPlatform($OSPlatform::OSX)} 
        
               $environment += @{'IsWindows' = $Runtime::IsOSPlatform($OSPlatform::Windows)} 
        
           } catch { 
        
               $environment += @{'IsCoreCLR' = $false} 
        
               $environment += @{'IsLinux' = $false} 
        
               $environment += @{'IsMacOS' = $false} 
        
               $environment += @{'IsWindows' = $true} 
        
           }

Steps to reproduce

Import-Module .\build.psm1
Get-EnvironmentInformation

Expected behavior

IsAdmin           : False
IsLinux           : False
IsCoreCLR         : False
IsWindows         : True
IsMacOS           : False
nugetPackagesRoot : C:\Users\MarkLocal\.nuget\packages

Actual behavior

IsAdmin           : False
IsLinux           : False
IsCoreCLR         : True
IsWindows         : True
IsMacOS           : False
nugetPackagesRoot : C:\Users\MarkLocal\.nuget\packages

Environment data

Name                           Value
----                           -----
PSVersion                      5.1.15063.726
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.726
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Steve Lee (@SteveL-MSFT)

/cc Steve Lee (@SteveL-MSFT) Maybe we should still remove $IsCoreCLR?

Ilya (@iSazonov)

Ilya (@iSazonov) This is unrelated to $IsCoreCLR.

Get-EnvironmentInformation is used inside the build.psm1 and packaging.psm1 only. The IsCoreClr key of the returned hashtable is used here

PowerShell/build.psm1

Line 1342 in 7dce411

if (-not $Environment.IsCoreCLR) {

and here

PowerShell/build.psm1

Line 1660 in 7dce411

if ((-not $NoNewWindow) -and ($Environment.IsCoreCLR)) {

Ah, sorry - today is a busy day.

I can not repo on my computer - both [System.Runtime.InteropServices.RuntimeInformation] and [System.Runtime.InteropServices.OSPlatform] throw. I think you load some assemblies in Windows PowerShell.

Ilya (@iSazonov)

Ilya (@iSazonov) what .NET version are you on? 4.7.1 has Both of those as available:

https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.runtimeinformation?view=netframework-4.7.1

https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.osplatform?view=netframework-4.7.1

Point is, those are not valid checks for CoreCLR anymore.

I am on 4.6.1

I can repro this after installing .Net 4.7.1. I think it would be fine to change the logic to assume Windows PowerShell 5.1 so we can use $PSVersionTable.PSEdition to determine if running on CoreCLR.

Navigation Menu

Repository navigation

Get-EnvironmentInformation does not properly check for CoreCLR #5581

Steps to reproduce

Expected behavior

Actual behavior

Environment data

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	# Use the .NET Core APIs to determine the current platform.
	# If a runtime exception is thrown, we are on Windows PowerShell, not PowerShell Core,
	# because System.Runtime.InteropServices.RuntimeInformation
	# and System.Runtime.InteropServices.OSPlatform do not exist in Windows PowerShell.
	try {
	$Runtime = [System.Runtime.InteropServices.RuntimeInformation]
	$OSPlatform = [System.Runtime.InteropServices.OSPlatform]

	$environment += @{'IsCoreCLR' = $true}
	$environment += @{'IsLinux' = $Runtime::IsOSPlatform($OSPlatform::Linux)}
	$environment += @{'IsMacOS' = $Runtime::IsOSPlatform($OSPlatform::OSX)}
	$environment += @{'IsWindows' = $Runtime::IsOSPlatform($OSPlatform::Windows)}
	} catch {
	$environment += @{'IsCoreCLR' = $false}
	$environment += @{'IsLinux' = $false}
	$environment += @{'IsMacOS' = $false}
	$environment += @{'IsWindows' = $true}
	}

Get-EnvironmentInformation does not properly check for CoreCLR #5581

Description

Steps to reproduce

Expected behavior

Actual behavior

Environment data

Activity

iSazonov commented on Nov 30, 2017

markekraus commented on Nov 30, 2017

iSazonov commented on Nov 30, 2017

markekraus commented on Nov 30, 2017

iSazonov commented on Nov 30, 2017

SteveL-MSFT commented on Nov 30, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions