Skip to content

convert all source and scripts to ascii with LF EOL #4752

New issue
New issue
Closed
Closed
convert all source and scripts to ascii with LF EOL#4752
Labels
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityResolution-FixedThe issue is fixed.
Milestone
6.1.0-Consider

Description

@SteveL-MSFT
Steve Lee (SteveL-MSFT)
opened on Sep 4, 2017

We have a number of strings that use the Copyright © symbol (0x00a9), but due to tools re-encoding files, the symbol gets mistranslated to the wrong unicode value. We should replace the text representation with the unicode value representation across all files. (Trademark character (0x2122) might also be used and should be replaced.

Activity

  1. Steve Lee (SteveL-MSFT)
    added
    Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionality
    Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors
    on Sep 4, 2017
  2. Michael Klement (mklement0)
    added a commit that references this issue on Sep 6, 2017

    Implements PowerShell#4752 and more [feature]: line endings standardi…

    588a3b8
  3. Steve Lee (SteveL-MSFT)
    self-assigned this
    on Sep 14, 2017
  4. Steve Lee (SteveL-MSFT)
    removed
    Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors
    on Sep 14, 2017
  5. Steve Lee (SteveL-MSFT)
    assigned
    Steve Lee (SteveL-MSFT)
    and unassigned
    Steve Lee (SteveL-MSFT)
    on Sep 24, 2017
  6. Steve Lee (SteveL-MSFT)
    changed the title [-]replace printed version of trademark/copyright character with unicode value[/-] [+]convert all source and scripts to ascii with LF EOL[/+] on Sep 27, 2017
  7. Steve Lee (SteveL-MSFT)
    added this to the milestone on Sep 27, 2017
  8. Steve Lee (SteveL-MSFT)
    removed their assignment
    on Sep 27, 2017

  9. SteveL-MSFT commented on Jun 20, 2018

    @SteveL-MSFT
    Steve Lee (SteveL-MSFT)
    on Jun 20, 2018
    MemberAuthor

    Copyright header was addressed by #6134

  10. SteveL-MSFT commented on Jun 20, 2018

    @SteveL-MSFT
    Steve Lee (SteveL-MSFT)
    on Jun 20, 2018
    MemberAuthor

    We made changes to gitattributes and vscode config so EOL should be fixed over time

  11. Steve Lee (SteveL-MSFT)
    closed this as completedon Jun 20, 2018
  12. Ilya (iSazonov)
    added
    Resolution-FixedThe issue is fixed.
    on Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityResolution-FixedThe issue is fixed.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions