Skip to content

MSI package should perform pre-req checks #4458

Closed

Description

@SteveL-MSFT

Windows Package has some pre-reqs required. MSI package should give a good error message directing user to download and install pre-reqs rather than failing at runtime with an unactionable error message.

Activity

  1. added this to the milestone on Aug 1, 2017
  2. bergmeister commented on Aug 14, 2017

    @bergmeister
    Contributor

    OK, so to summarize:

    • Universal C Runtime prior to Windows 10
    • Visual C++ Redistributable for VS2015 (the link to it in the pre-reqs does not work for people without an MSDN subscription by the way)

    Steve Lee (@SteveL-MSFT) Aditya Patwardhan (@adityapatwardhan) I think I might be able to help with the 2nd item by following this approach from the official WiX guideline, which is to include and install the Visual C++ redistributables as part of the MSI installer. WDYT?

  3. adityapatwardhan commented on Aug 14, 2017

    @adityapatwardhan
    Member

    Christoph Bergmeister (@bergmeister) I think that might work. Thanks!

  4. added a commit that references this issue on Aug 16, 2017
  5. bergmeister commented on Aug 16, 2017

    @bergmeister
    Contributor

    Due to the fact that the Visual C++ team has made significant refactorings in 2015 (see here), the initial approach of including them as a merge module in the MSI has been deprecated. The alternatives are complex and therefore I think it is best to go back to just giving an error message as initially proposed by Steve.

  6. bergmeister commented on Aug 16, 2017

    @bergmeister
    Contributor

    Aditya Patwardhan (@adityapatwardhan) : I created the pull request #4602 for it.

  7. added 2 commits that reference this issue on Aug 17, 2017
  8. SteveL-MSFT commented on Aug 28, 2017

    @SteveL-MSFT
    MemberAuthor

    There's an open issue #4665 for this, but we can consider this one closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions