Apostrophe in filepath breaks Import-Module when the module has a class in it #4193

Activity

1. iSazonov commented on Jul 7, 2017

   

   Ilya (iSazonov)

   on Jul 7, 2017

   Last edited by iSazonov

   Collaborator

   More actions

   Leo D'Arcy (@ld0614) Thanks for your report!
   Related PR #4136 - it seems we need full review allowed chars for "file names" vs "assembly names".
2. Ilya (iSazonov)

   added

   WG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime

   Issue-BugIssue has been identified as a bug in the productIssue has been identified as a bug in the product

   on Jul 7, 2017
3. Steve Lee (SteveL-MSFT)

   added

   Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors

   on Jul 7, 2017
4. ld0614 commented on Jul 7, 2017

   

   Leo D'Arcy (ld0614)

   on Jul 7, 2017

   Author

   More actions

   I've written a (very quick and VERY dirty) script which loops through all visible ASCII chars and outputs the ones that fail. In version 5.1 the following fail: 39 ('), 44 (,) and 61 (=). Interestingly enough testing with version 6.0 Beta 3 the same 3 fail as well as 126 (~)

   $InvalidDirectoryChars = 34,42,47,58,60,62,63,92,124
   $FailedChars = @()
   
   for ($i = 32; $i -lt 255; $i++)
   {
       $PathName = "C:\Temp\$($i)Te$([Char]$i)mp"
       if ($InvalidDirectoryChars -notcontains $i)
       {
           $Directory = New-Item -ItemType Directory -Path $PathName -Force -ErrorAction SilentlyContinue
           if ($Directory -eq $null)
           {
               Write-Output "Char $([Char]$i) is not a valid folder name number is: $i"
           }
           else
           {
               Copy-Item C:\Temp\Sample\* $PathName -Force
           }
           if ($i -ne 91)
           {
               Import-Module $PathName\FunctionModule.psm1 -ErrorAction SilentlyContinue -Force
           }
           else
           {
               Import-Module 'C:\Temp\91Te`[mp\FunctionModule.psm1' -Force
           }
           $FunctionModule = Get-Module FunctionModule
           if ($FunctionModule.Path -eq "$PathName\FunctionModule.psm1")
           {
               Write-Host "Char $i Loaded FunctionModule Correctly" -ForegroundColor Green
           }
           else
           {
               Write-Host "Char $i failed to load FunctionModule" -ForegroundColor Red
           }
   
           if ($i -ne 91)
           {
               Import-Module $PathName\ClassModule.psm1 -ErrorAction SilentlyContinue
           }
           else
           {
               Import-Module 'C:\Temp\91Te`[mp\ClassModule.psm1' -Force
           }
           $ClassModule = Get-Module ClassModule
           if ($ClassModule.Path -eq "$PathName\ClassModule.psm1")
           {
               Write-Host "Char $i Loaded ClassModule Correctly" -ForegroundColor Green
           }
           else
           {
               Write-Host "Char $i failed to load ClassModule" -ForegroundColor Red
               $FailedChars += $i
           }
       }
   }
   
   Write-Output "Failed Chars are:"
   $FailedChars
   

   👍React with 👍1Reacted by Steve Lee
5. iSazonov commented on Jul 8, 2017

   

   Ilya (iSazonov)

   on Jul 8, 2017

   Collaborator

   More actions

   This can vary on different platforms. We need more predictable way. I tried to find root code in CoreCLR repo. It seems the exception is here and failed code is here but I was not able to take the next step 😕
6. TimCurwick commented on Jul 13, 2017

   

   Tim Curwick (TimCurwick)

   on Jul 13, 2017

   Contributor

   More actions

   Whether or not this eventually gets fixed at the .Net level, I presume we want to add the work arounds in the PowerShell code in the meantime.

   I can add three more Replace methods to the one that was merged last week for the comma.

   We can use ’, [char]0x2019, the right quotation mark, to replace the apostrophe.
   We can use ∼, [char]0x223C, the tilde operator, to replace the tilde.

   The equals sign is not as straightforward.
   ＝, [char]0xFF1D, the full width equals sign, as the only character I can find that looks like an equals sign is the most likely choice. The downside is that it is very wide, with whitespace built in, making it wider than standard ASCII characters, which throws off the spacing in plain text, which is probably no big deal but feels weird.
   ≃, [char]0x2248; ≐, [char]0x2250; and ≕, [char]0x2255 are close, but not quite matches for an equals sign. They, too, are wider than standard ASCII characters by varying amounts, but not as wide as the full width equals sign.
   ≈, [char]0x2243, is the right width, but it looks the least like an equals sign of the alternatives, and mathematically has a different meaning than an equals sign (almost or approximately equals). (The above three alternatives also have different meanings, but are less common so fewer people would be bothered by their mathematical differences.)
7. rkeithhill commented on Jul 14, 2017

   

   Keith Hill (rkeithhill)

   on Jul 14, 2017

   Collaborator

   More actions

   And don't forget that you can now use the Unicode esc sequence in dq strings e.g. "`u{2019}". :-)

   😄React with 😄1Reacted by Steve Lee
8. Jason Shirk (lzybkr)

   self-assigned this

   on Aug 25, 2017
9. Jason Shirk (lzybkr)

   removed

   Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors

   on Aug 25, 2017
10. donlassini commented on Nov 26, 2017

    

    DonLassini (donlassini)

    on Nov 26, 2017

    More actions

    This can also be reproduced in a simpler set up:
    Save the TypeName.psm1 file as TypeName.ps1 and execute that.
    You will get an error if e.g. the path contains a comma.
11. lzybkr commented on Nov 26, 2017

    

    Jason Shirk (lzybkr)

    on Nov 26, 2017

    Contributor

    More actions

    DonLassini (@donlassini) - this bug was fixed in 71d5439 - are you still seeing the problem in the latest build?
12. iSazonov commented on Nov 27, 2017

    

    Ilya (iSazonov)

    on Nov 27, 2017

    Last edited by iSazonov

    Collaborator

    More actions

    I can confirm that we can import module with apostrophe in the file path in latest builds.
13. Jason Shirk (lzybkr)

    closed this as completedon Nov 27, 2017
14. Ilya (iSazonov)

    added

    Resolution-FixedThe issue is fixed.The issue is fixed.

    on Nov 27, 2017