Skip to content

How far should we go to make up for missing features in other OSS projects? #3187

Closed

Description

Especially with regard to Pester as we rely on it as our test infrastructure, but sometimes Pester does not have a feature which we would like. Should we code up our own solution and use it?

I am very concerned about this because it does not help the Pester community and places a burden on anyone who wishes to use our solution to get one more module, or script. Specifically, when checking for error conditions, we would rather validate against FullyQualifiedErrorId rather than the message (which is what Pester provides). I would be happier to have a PR filed on Pester which implements an assertion for something like ThrowFullyQualifiedErrorId (or similar) rather than coding around this in our own code. This allows Pester to have something generally useful and avoid more and more unneeded custom code.

Activity

  1. added
    WG-Quality-Testissues in a test or in test infrastructure
    Issue-Discussionthe issue may not have a clear classification yet. The issue may generate an RFC or may be reclassif
    on Feb 23, 2017
  2. lzybkr commented on Feb 23, 2017

    @lzybkr
    Contributor

    We can provide our guidance and experience to other projects and offer PRs, but we can't make other projects accept our ideas.

    We can learn a lot from applying what we think is a better solution by actually implementing our idea first in our own code. When we've worked out the details - we can move on to a PR that works well for us.

  3. iSazonov commented on Feb 23, 2017

    @iSazonov
    Collaborator

    This is the best way to use a Pester major version and improve it. But the current versions of Pester is not ported. pester/Pester#673 Even if the desired improvements already exist, we cannot use them.

    Perhaps we should add the migration to a new Pester version in our Plan (6.0 roadmap) because it will be very strange to deploy the latest release of Powershell 6.0 with very old (two year?) Pester module.

  4. iSazonov commented on Aug 29, 2018

    @iSazonov
    Collaborator

    Currently we use latest Pester version which support many new features including Should -Be -Throw. Also we convert all our tests to use new Pester 4.0 syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Discussionthe issue may not have a clear classification yet. The issue may generate an RFC or may be reclassifResolution-AnsweredThe question is answered.WG-Quality-Testissues in a test or in test infrastructure

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions