Skip to content

Fix group policy cache #2877

New issue
New issue
Closed
Closed
Fix group policy cache#2877
Labels
Resolution-FixedThe issue is fixed.WG-Enginecore PowerShell engine, interpreter, and runtime

Description

@PaulHigin
Paul Higinbotham (PaulHigin)
opened on Dec 13, 2016

The internal Group Policy cache does not use a unique key and ends up returning MachinePolicy ExecutionPolicy for a UserPolicy query.

Update the cache code to use a fully unique key.

Investigate using a Tuple instead of concatenated string for the cache key to improve performance.

Steps to reproduce

Set Group Policy UserPolicy, ExecutionPolicy to RemoteSigned
Start new PowerShell session
Run 'Get-ExecutionPolicy -List'

Expected behavior

ExecutionPolicy UserPolicy set to RemoteSigned

Actual behavior

ExecutionPolicy UserPolicy set to Undefined

Activity

  1. Joey Aiello (joeyaiello)
    added
    WG-Enginecore PowerShell engine, interpreter, and runtime
    on Dec 14, 2016

  2. iSazonov commented on Jan 20, 2018

    @iSazonov
    Ilya (iSazonov)
    on Jan 20, 2018
    Collaborator

    /cc Dongbo Wang (@daxian-dbw) It seems you already improved the code.

  3. daxian-dbw commented on Jan 22, 2018

    @daxian-dbw
    Dongbo Wang (daxian-dbw)
    on Jan 22, 2018
    Member

    I verified the reproduce steps on PSCore 6.0.0 and the issue seems to be fixed:

    PS:4> Get-Item HKCU:\Software\Policies\Microsoft\PowerShellCore

    Hive: HKEY_CURRENT_USER\Software\Policies\Microsoft

Name                           Property
----                           --------
PowerShellCore                 EnableScripts   : 1
                               ExecutionPolicy : RemoteSigned

PS:5> Get-ExecutionPolicy -List

        Scope ExecutionPolicy
        ----- ---------------
MachinePolicy       Undefined
   UserPolicy    RemoteSigned
      Process       Undefined
  CurrentUser       Undefined
 LocalMachine    RemoteSigned

    Given that, I'm closing this issue. Paul Higinbotham (@PaulHigin) Feel free to re-open this issue if you think it's not fixed.

  4. Dongbo Wang (daxian-dbw)
    closed this as completedon Jan 22, 2018

  5. PaulHigin commented on Jan 22, 2018

    @PaulHigin
    Paul Higinbotham (PaulHigin)
    on Jan 22, 2018
    ContributorAuthor

    Dongbo Wang (@daxian-dbw) Why do we assume this is fixed? Please provide a link to the PR that fixed it.

  6. daxian-dbw commented on Jan 22, 2018

    @daxian-dbw
    Dongbo Wang (daxian-dbw)
    on Jan 22, 2018
    Member

    Here is the PR: #5791 The group policy cache was redesigned in that PR.

  7. PaulHigin commented on Jan 22, 2018

    @PaulHigin
    Paul Higinbotham (PaulHigin)
    on Jan 22, 2018
    ContributorAuthor

    Thanks. Agreed that this is no longer an issue.

  8. Ilya (iSazonov)
    added
    Resolution-FixedThe issue is fixed.
    on Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Resolution-FixedThe issue is fixed.WG-Enginecore PowerShell engine, interpreter, and runtime

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions