Skip to content

Enable CA1852: Seal internal types #24094

New issue
New issue
Closed
#25890
Closed
Enable CA1852: Seal internal types#24094
#25890

Description

@xtqqczze
xtqqczze
opened on Jul 28, 2024

When a type isn't accessible outside its assembly and has no subtypes within its containing assembly, it can be safely sealed.

https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852

Activity

  1. microsoft-github-policy-service
    added
    Resolution-No ActivityIssue has had no activity for 6 months or more
    on Jan 27, 2025
  2. microsoft-github-policy-service
    closed this as completedon Feb 3, 2025
  3. Ilya (iSazonov)
    reopened this on Feb 4, 2025
  4. microsoft-github-policy-service
    closed this as completedon Feb 11, 2025
  5. Ilya (iSazonov)
    reopened this on Feb 12, 2025
  6. Ilya (iSazonov)
    removed
    Resolution-No ActivityIssue has had no activity for 6 months or more
    on Feb 12, 2025

  7. iSazonov commented on Feb 12, 2025

    @iSazonov
    Ilya (iSazonov)
    on Feb 12, 2025
    Collaborator

    What is a progress in fixing the rule?

  8. microsoft-github-policy-service
    added
    Resolution-No ActivityIssue has had no activity for 6 months or more
    and removed
    Resolution-No ActivityIssue has had no activity for 6 months or more
    on Aug 11, 2025
  9. xtqqczze
    added a commit that references this issue on Aug 12, 2025

    Seal internal types in `src/Microsoft.PowerShell.Commands.Management`

    dda7681
  10. xtqqczze
    added 5 commits that reference this issue on Aug 22, 2025

    Enable CA1852: Seal internal types

    6204957

    Seal internal types in `Microsoft.PowerShell.Commands.Utility`

    dc497d7

    Enable CA1852: Seal internal types

    02f5e9f

    Enable CA1852: Seal internal types

    25e6142

    Enable CA1852: Seal internal types

    ea67269
  11. xtqqczze
    added a commit that references this issue on Sep 25, 2025

    Enable CA1852: Seal internal types

    8545c74
  12. xtqqczze
    added a commit that references this issue on Oct 8, 2025

    Enable CA1852: Seal internal types

    51c1a7c
  13. xtqqczze
    added a commit that references this issue on Oct 16, 2025

    Enable CA1852: Seal internal types

    c511157
  14. microsoft-github-policy-service
    added
    Resolution-No ActivityIssue has had no activity for 6 months or more
    and removed
    Resolution-No ActivityIssue has had no activity for 6 months or more
    on Feb 22, 2026
  15. Dongbo Wang (daxian-dbw)
    closed this as completedin #25890on Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions