Skip to content

Modules like PowerShell Get need the version bumped up when modified #2136

Closed

Description

@kilasuit

https://github.com/PowerShell/PowerShell/blob/master/src/Modules/Shared/PowerShellGet/PowerShellGet.psd1 - This still shows 1.0.0.1 for the module version (same version as the module that was bundled with Win10 10586) even though there have been a number of changes to this module since July 2015

This follows on from the request in #1979 to decouple any included modules like PowerShell Get so that with these modules we can have a build & release process that we have confidence in and this is becoming more and more important to get right as the number of changes to this Repository grows.

Activity

  1. zipzit commented on Aug 31, 2016

    @zipzit

    If you are a user, is there any way to determine which version of powershell you are running?
    powershell help and powershell help version reveal nothing. powershell --version and powershell -ver reveal nothing. There is no menu select for "About" or anything related. And why isn't such a command available by an observer starting at powershell help ?

    Why the big secret? Is the version level such a big secret, or am I just doing this wrong?

  2. kilasuit commented on Aug 31, 2016

    @kilasuit
    CollaboratorAuthor

    Zip (@zipzit) you would have to start powershell and then run

    $PSVersionTable.PSVersion

    that is the correct way to find the version of PowerShell that you are running.

    If you are new to using powershell then take a look at the following learning powershell page at https://github.com/PowerShell/PowerShell/blob/master/docs/learning-powershell

  3. bmanikm commented on Sep 28, 2016

    @bmanikm
    Contributor

    Fixed this for PowerShellGet module in #2372

  4. kilasuit commented on Sep 29, 2016

    @kilasuit
    CollaboratorAuthor

    Manikyam Bavandla (@bmanikm) It may be fixed for PowerShellGet however this needs to be enforced on all inbox shipped modules until #1979 has been completed and each module has decoupled and has a reliable and robust build process that all users can trust in which is especially truthful of all MS released modules

    Currently I haven't got that level of trust that any change in any of the modules shipped inside of this repository, regardless of the size of the change, couldn't end up bringing an unforeseen breaking change somewhere else down the line.

    Don't get me wrong as now PowerShell has been Open Sourced the direction is going the right way to being able to actually have that level of trust however there is still work to be done to get us there so could you re-open this until #1979 has been completed

  5. bmanikm commented on Sep 29, 2016

    @bmanikm
    Contributor

    Thanks Ryan Yates (@kilasuit)!, I have updated my above comment.

  6. added this to the milestone on Nov 1, 2016
  7. SteveL-MSFT commented on Nov 1, 2016

    @SteveL-MSFT
    Member

    Zip (@zipzit) getting the powershell version using -version without argument makes sense - Looks like it's #1084

  8. removed this from the milestone on May 25, 2017
  9. joeyaiello commented on May 25, 2017

    @joeyaiello
    Contributor

    We should do this, but I think it's probably more in line with whenever we do the module refactoring.

  10. kilasuit commented on Jun 14, 2018

    @kilasuit
    CollaboratorAuthor

    Bumping this to get a review - is this something that the internal modules to PSCore that aren't being decoupled in #1979 are getting their versions updated when there are updates to them?

  11. kilasuit commented on Jan 22, 2019

    @kilasuit
    CollaboratorAuthor

    Steve Lee (@SteveL-MSFT) are changes to the modules that are bundled as part of PSCore getting version bumped at all? Because technically they should be in line with the version of PSCore unless they can be decoupled further as part of #1979 which would help #5681 out

  12. SteveL-MSFT commented on Jan 22, 2019

    @SteveL-MSFT
    Member

    Ryan Yates (@kilasuit) we haven't been keeping the module version updated with the PSCore6 version partly because it's manual and partly because the modules aren't separate. Once decoupled, it will be easier to have them rev as needed.

  13. kilasuit commented on May 21, 2020

    @kilasuit
    CollaboratorAuthor

    I think this can be closed now as many modules got decoupled and they now have proper versioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Metaan issue used to track multiple issuesWG-Cmdletsgeneral cmdlet issuesWG-Maintainers-Buildspecific to affecting the build

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions