Skip to content

IFeedbackProvider should be able to be called when there is not an error #19372

Closed

Description

Summary of the new feature / enhancement

It should be possible to call the predictor in those cases where there wasn't an error.
For example, if the user types a command which was successful, but there is a better way to express the operation.
ex.

PS> uname -a

could be prompted to run

PS> uname -a | jc --uname | convertfrom-json

if the jc command is installed.

Proposed technical implementation details (optional)

No response

Activity

  1. JamesWTruher commented on Mar 20, 2023

    @JamesWTruher
    CollaboratorAuthor

    this is related to: #19364

  2. daxian-dbw commented on Mar 20, 2023

    @daxian-dbw
    Member

    James Truher (@JamesWTruher) I think you mean the IFeedbackProvider.

  3. changed the title [-]ICommandPredictor should be able to be called when there is not an error[/-] [+]IFeedbackProvider should be able to be called when there is not an error[/+] on Mar 20, 2023
  4. StevenBucher98 commented on May 15, 2023

    @StevenBucher98
    Collaborator

    Closing because this is fixed in #19525

  5. ghost removed
    Needs-TriageThe issue is new and needs to be triaged by a work group.
    on May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Enhancementthe issue is more of a feature request than a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions