Skip to content

Do we need Enable-RunspaceDebug.Tests.ps1 file? #13470

New issue
New issue
Closed
#16269
Closed
Do we need Enable-RunspaceDebug.Tests.ps1 file?#13470
#16269
Labels
Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-FixedThe issue is fixed.Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsWG-Quality-Testissues in a test or in test infrastructure

Description

@sethvs
Sergey Vasin (sethvs)
opened on Aug 18, 2020

Do we need Enable-RunspaceDebug.Tests.ps1 file?

https://github.com/PowerShell/PowerShell/blob/master/test/powershell/Modules/Microsoft.PowerShell.Utility/Enable-RunspaceDebug.Tests.ps1 was added as part of #8923, then in #10338 the functionality it tests was removed.

When run, its tests are skipped because Microsoft.PowerShell.Utility.PSDebugRunspaceWithBreakpoints experimental feature doesn't exist, or else the tests would fail.

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Utility/Enable-RunspaceDebug.Tests.ps1

Lines 9 to 14 in 904e551

if (!$FeatureEnabled) {
Write-Verbose "Test Suite Skipped. The test suite requires the experimental feature 'Microsoft.PowerShell.Utility.PSDebugRunspaceWithBreakpoints' to be enabled." -Verbose
$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()
$PSDefaultParameterValues["it:skip"] = $true
return
}

Should we remove the file?

Steps to reproduce



Expected behavior






Actual behavior






Environment data





Activity
  1. Sergey Vasin (sethvs)
    added 
    Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get a
     on Aug 18, 2020
  2. vexx32 commented on Aug 18, 2020 
    @vexx32
    Rain Sallow (/u/ta11ow) (vexx32)
    on Aug 18, 2020
    Collaborator
    Wasn't this recently added back in during the most recent preview cycle? 🤔
  3. iSazonov commented on Aug 20, 2020 
    @iSazonov
    Ilya (iSazonov)
    on Aug 20, 2020
    Collaborator
    /cc TylerLeonhardt
  4. Ilya (iSazonov)
    added 
    WG-Quality-Testissues in a test or in test infrastructure
     on Aug 20, 2020
  5. Ilya (iSazonov)
    added 
    Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors
     on Jan 18, 2021
  6. ghost added 
    In-PRIndicates that a PR is out for the issue
     on Oct 18, 2021
  7. Ilya (iSazonov)
    closed this as completedin #16269on Oct 19, 2021
  8. ghost removed 
    In-PRIndicates that a PR is out for the issue
     on Oct 19, 2021
  9. ghost added 
    Resolution-FixedThe issue is fixed.
     on Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Metadata
Assignees
No one assigned
    Labels
    Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-FixedThe issue is fixed.Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsWG-Quality-Testissues in a test or in test infrastructure
    Type
    No type
    Projects
    No projects
      Milestone
      No milestone
      Relationships
      None yet
      Development
      No branches or pull requests
      Issue actions