Repository navigation
Implement Invoke-Item/Get-Help -Online for .NET Core on Windows and Nano #1325
Description
Per #1291, we've discovered that Invoke-Item and Get-Help -Online are broken for .NET Core on Windows and Nano due to UseShellExecute being unavailable.
One approach for Windows (but not Nano) is recorded in 6200f08. While this works for .NET Core on Windows by shelling out to cmd.exe "start ..." (essentially replacing UseShellExecute) it still poses a problem on Nano as the latter won't have any browser (or other default applications) to invoke.
At this point, PowerShell does not really differentiate between PowerShell on Nano and PowerShell on Windows built with .NET Core, but the latter has become a valid, and different, flavor with PowerShell Core. We'll need a proper way to detect whether or not the underlying OS is Nano, without depending on the target framework being .NET Core. (Done: [System.Management.Automation.Platform]::IsIoT and [System.Management.Automation.Platform]::IsNanoServer)
Breaking down issue 1325 into two as they required different approaches.
- [ ]
Implement Invoke-Item for .NET Core on Windows, Nano Server and IoT (Implement Invoke-Item for .NET Core on Windows, Nano Server and IoT #2272)
To fix this issue, a possible solution is to wrap the call in cmd.exe “start...”; however, in order to figure out if the process fail to start, we need WaitForExit, then check the exit code, and extract the standard error. This is a change on behavior between Full and CoreCLR PowerShell. The problem with this implementation is that PowerShell will be blocked until the process completes. Alternatively, if we decide to just ignore the error, then this behavior will also be incorrect since in PowerShell no error means the operation was successful.
We should explore doing a PInvoke in Windows CoreCLR. This way, we can get the Marshal.GetLastWin32Error() if we fail to start the process.
- [ ]
Implement Get-Help -Online for .NET Core on Windows, Nano Server, and IoT
(Implement Get-Help -Online for .NET Core on Windows, Nano Server, and IoT #2271)
To fix this issue, we should write code that checks if there is default browser. If there isn’t (which is the Nano Server and IoT scenario), we error out. If there is, we can wrap the call in cmd.exe “start …”
Activity
andyleejordan commentedon Jul 26, 2016
Moving milestone per #1506.
iSazonov commentedon Oct 7, 2016
Andy Jordan (@andschwa) IsNanoServer and IsIoT is defined in CorePsPlatform.cs
(May be add their to SpecialVariables.cs for use in tests?)
andyleejordan commentedon Oct 7, 2016
Ilya (@iSazonov) They weren't in July 😄 and this is owned by Francisco Gamino (@Francisco-Gamino)
iSazonov commentedon Oct 8, 2016
Andy Jordan (@andschwa) Thanks for the clarification.
Could you please strike through the text?
Andy Jordan (@andschwa) and Francisco Gamino (@Francisco-Gamino) Whether to open a new issue for "add IsNanoServer and IsIoT to SpecialVariables.cs for use in tests"?
daxian-dbw commentedon Oct 10, 2016
Ilya (@iSazonov) I updated the issue description to make it clearer.
I'm a little hesitating about adding automatic variable
$IsIoTand$IsNanoServerin powershell core. Differences between powershell core on windows and Nano/IoT powershell are mainly in:-- the difference should be transparent to user: $env:psmodulepath and $profile will have the correct setting on those platforms.
--
$IsIoTand$IsNanoServercould be helpful when a module implementation depends on native win32 APIs. But I guess that's not common and you can always check$PSHometo tell if you are running on a inbox powershell (indicating NanoServer and IoT).Given that, I feel it's possibly more like a developer's need to have
$IsIoTand$IsNanoServer-- easier to write tests, not a user's need.iSazonov commentedon Oct 11, 2016
Dongbo Wang (@daxian-dbw) Thanks for the update.
If [System.Management.Automation.Platform]::IsIoT and [System.Management.Automation.Platform]::IsNanoServer can be used in the tests, then my question is closed.
Discussion about adding variables and end user UX I believe should be in a separate Issue.
daxian-dbw commentedon Oct 12, 2016
This issue has been separated into 2 sub issues:
Get-Help -Online(#2271) andInvoke-Item(#2272).