More function should support pipelining

The current definition of more does not pipeline, it collects all output in $input and then pipes to more after the upstream command finishes.

It's a duplicate of #559

Ideally, we should implement it for 0.7.0 milestone, so we have some time for stabilization.
I see this issue as one of the major usability blockers.

It's related, but not a dupe. The implementation of the more function needs to change, it doesn't stream even when not calling native commands, e.g.

& { 1..100; sleep -seconds 10; 101..200 } | more

You'll see no output for 10 seconds.

Still don't understand why it's different. More calls internally native pager.

# Respect PAGER, use more on Windows, and use less on Linux
if (Test-Path env:PAGER) {
  $moreCommand = (Get-Command -CommandType Application $env:PAGER).Definition | Select-Object -First 1
} elseif ($IsWindows) {
  $moreCommand = (Get-Command -CommandType Application more).Definition | Select-Object -First 1
} else {
  $moreCommand = (Get-Command -CommandType Application less).Definition | Select-Object -First 1
}

If you used an internal pager (which more doesn't allow for, but should), a fix to the native command processor wouldn't help.

The more function doesn't have a process block, so $input is collected until it's done, then the end block is called.

What is this internal pager? Do we use it anywhere?

out-host -paging - it's bad, nobody uses it. But if I wanted to write a cmdlet to page, more should call it somehow, not sure if it should be via $env:PAGER or not (probably not, external tools use that same env var).

As far as I see, if we fix #559 then we will also have a problem with out-host -paging, but we can ignore it, because nobody uses it.

I'm playing around with NativeCommandProcessor.cs.
What's the right label for "work in progress"? Is it 3 -Working?

I take 3 - Working to mean the assignee is working on it.
As for 2 - Ready - to me that means more or less up for grabs, design not really an issue, or design is resolved.

Jason Shirk (@lzybkr)

Jason Shirk (@lzybkr) per our conversation with the @PowerShell/powershell-maintainers, would this actually be something that goes to 0 - Backlog? And if so, what's the intended purpose of 2 - Ready?

Jason Shirk (@lzybkr)

Jason Shirk (@lzybkr) I attached a script file to address the Issue. Could you please look when you'll have free time? If it is right direction I'll push a PR.
Next-More.txt

Navigation Menu

Repository navigation

More function should support pipelining #1267

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

More function should support pipelining #1267

Description

Activity

vors commented on Jul 2, 2016

lzybkr commented on Jul 3, 2016

vors commented on Jul 3, 2016

lzybkr commented on Jul 3, 2016

vors commented on Jul 3, 2016

lzybkr commented on Jul 3, 2016

vors commented on Jul 3, 2016

vors commented on Jul 3, 2016

lzybkr commented on Jul 3, 2016

joeyaiello commented on Sep 2, 2016

iSazonov commented on Jan 18, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions