Write test to exclude UTF-8 BOM from files in tree #11554

Activity

1. xtqqczze

   added

   Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get a

   on Jan 10, 2020
2. xtqqczze commented on Jan 10, 2020

   

   xtqqczze

   on Jan 10, 2020

   ContributorAuthor

   More actions

   We could use the following code to test for BOM:

   filter hasBom {
       $_.Where{
           $bytes = [byte[]]::new(3)
           $stream = [System.IO.File]::OpenRead($_.FullName)
           $stream.Read($bytes, 0, 3) > $null
           $stream.Close()
           $bytes[0] -eq 0xef -and $bytes[1] -eq 0xbb -and $bytes[2] -eq 0xbf
       }
   }
3. xtqqczze

   changed the title [-]Write test for UTF-8 BOM[/-] [+]Write test to exclude UTF-8 BOM from files in tree[/+] on Jan 10, 2020
4. iSazonov commented on Jan 11, 2020

   

   Ilya (iSazonov)

   on Jan 11, 2020

   Collaborator

   More actions

   Travis Plunk (@TravisEz13) Should it be in static tests?
5. Ilya (iSazonov)

   added

   WG-Quality-Testissues in a test or in test infrastructureissues in a test or in test infrastructure

   Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bug

   and removed

   Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get a

   on Jan 11, 2020
6. TravisEz13 commented on Jan 11, 2020

   

   Travis Plunk (TravisEz13)

   on Jan 11, 2020

   Member

   More actions

   Ilya (@iSazonov) yes, this should be a static test.

   👍React with 👍1Reacted by Ilya
7. xtqqczze commented on Jan 20, 2020

   

   xtqqczze

   on Jan 20, 2020

   Last edited by unfurl-links

   ContributorAuthor

   More actions

   We should consider setting a code analyzer rule to check for BOM:

   

   https://github.com/maroontress/StyleChecker/blob/master/doc/rules/ByteOrderMark.md

   

   GitHub

   maroontress/StyleChecker

   StyleChecker is yet another code style checker and refactoring tool like FxCopAnalyzers, StyleCop Analyzers, SonarLint, Roslynator, and so on. - maroontress/StyleChecker
8. iSazonov commented on Jan 21, 2020

   

   Ilya (iSazonov)

   on Jan 21, 2020

   Collaborator

   More actions

   We could use code analyzer(s) on server side although a script would be more simple.
9. xtqqczze commented on Jan 21, 2020

   

   xtqqczze

   on Jan 21, 2020

   ContributorAuthor

   More actions

   Ilya (@iSazonov) If we use a code analyzer rule running on PowerShell-CI-static-analysis, we could use the same rule in a local build and for live analysis in the development environment.
10. xtqqczze commented on Jan 22, 2020

    

    xtqqczze

    on Jan 22, 2020

    ContributorAuthor

    More actions

    See #11654
11. xtqqczze commented on Jan 22, 2020

    

    xtqqczze

    on Jan 22, 2020

    ContributorAuthor

    More actions

    When DotNetAnalyzers/StyleCopAnalyzers#2100 is implemented we could add the rule for analysis.
12. iSazonov commented on Jan 22, 2020

    

    Ilya (iSazonov)

    on Jan 22, 2020

    Collaborator

    More actions

    I believe PowerShell script in our static analysis will be simple, fast and reliable.
13. microsoft-github-policy-service commented on Nov 16, 2023

    

    microsoft-github-policy-serviceBot

    on Nov 16, 2023 – with Microsoft GitHub Policy Service

    Contributor

    More actions

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
14. microsoft-github-policy-service commented on Nov 16, 2023

    

    microsoft-github-policy-serviceBot

    on Nov 16, 2023 – with Microsoft GitHub Policy Service

    Contributor

    More actions

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
15. microsoft-github-policy-service commented on Nov 16, 2023

    

    microsoft-github-policy-serviceBot

    on Nov 16, 2023 – with Microsoft GitHub Policy Service

    Contributor

    More actions

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
16. microsoft-github-policy-service

    added

    Resolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or more

    on Nov 16, 2023
17. microsoft-github-policy-service commented on Nov 23, 2023

    

    microsoft-github-policy-serviceBot

    on Nov 23, 2023 – with Microsoft GitHub Policy Service

    Contributor

    More actions

    This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.
18. microsoft-github-policy-service

    closed this as completedon Nov 23, 2023