kicad: 7.0.10 -> 8.0.1 by evils · Pull Request #291134 · NixOS/nixpkgs

evils · 2024-02-24T12:55:45Z

Description of changes

7.0.11 release blog post
8.0.0 release blog post
8.0.1 release blog post

Things done

bump 7.0.10 to 7.0.11 (included separately to stay reachable and be backported to 23.11)
bump kicad-unstable to 2024-02-07 (fixes its build, adds dependencies that are now part of 8.0.0, update wrapper env vars)
bump 7.0.11 to 8.0.0 (uses the kicad-unstable new dependencies and env var wrappers)
(also bumps kicad-unstable and kicad-testing, should be almost exactly the same at the moment)

Add a 👍 reaction to pull requests you find important.

evils · 2024-02-24T13:06:01Z

ping KiKit maintainers @jfly @matusf
it appears this breaks kikit etc.
(kicadAddons.kikit kicadAddons.kikit-library kikit kikit.dist)

bgamari · 2024-02-24T13:20:40Z

Thanks for handling this, @evils!

evils · 2024-02-24T13:37:00Z

i suggest this approach for KiKit:
keep 23.11 on 7.x where stable KiKit will keep working
update KiKit on nixos-unstable to master, where it seems the compatibility is already fixed

evils · 2024-02-24T13:38:28Z

also @jfly i've edited your runtime data path patch's env var to use KICAD8 to match up with the other env vars, i hope that's ok

evils · 2024-02-24T14:01:13Z

oh and on sway (wayland) with mixed DPI monitors this may have trouble getting an appropriate area
this may be a wxwidgets issue and may be resolved on their master branch, i haven't looked into it for a while...

jfly

Thanks, @evils! For the record, kikit does not seem to be buildable on this branch. How I tested:

$ nix-build -E 'let pkgs = import (builtins.fetchTarball { url = "https://github.com/NixOS/nixpkgs/archive/e70e1370a88f86ea989902e140172e9cff0d379a.tar.gz"; }) {}; in pkgs.kicad.override {addons=[pkgs.kicadAddons.kikit pkgs.kicadAddons.kikit-library];}'
...
not ok 38 Dumping preset with plugin
# (in test file /build/source/test/system/panelize.bats, line 301)
#   `kikit panelize --dump preset-plugin.json \' failed
# 01:58:47: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied)
# 01:58:47: Error: Directory '/homeless-shelter/.config/kicad/8.0' couldn't be created (error 2: No such file or directory)
# An error occurred: module 'pcbnewTransition.pcbnew' has no attribute 'EDA_RECT'
# No output files produced
# Traceback (most recent call last):
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/panelize_ui.py", line 217, in panelize
#     doPanelization(input, output, preset, plugin)
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/panelize_ui.py", line 266, in doPanelization
#     ki.buildLayout(preset, panel, input, sourceArea)
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/panelize_ui_impl.py", line 268, in buildLayout
#     substrates = lPlugin.buildLayout(panel, sourceBoard, sourceArea)
#                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#   File "/build/source/test/resources/testplugin.py", line 33, in buildLayout
#     panel.appendBoard(inputFile, pcbnew.wxPointMM(0, 0), sourceArea)
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/panelize.py", line 991, in appendBoard
#     drawings = collectItems(board.GetDrawings(), enlargedSourceArea)
#                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/common.py", line 83, in collectItems
#     return list([x for x in boardCollection if fitsIn(x.GetBoundingBox(), sourceArea)])
#                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/common.py", line 83, in <listcomp>
#     return list([x for x in boardCollection if fitsIn(x.GetBoundingBox(), sourceArea)])
#                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#   File "/nix/store/79gz22x7k5q7755hzcnz501g0is7fsd3-kikit-1.4.0/lib/python3.11/site-packages/kikit/common.py", line 49, in fitsIn
#     assert isinstance(what, (BOX2I, VECTOR2I, pcbnew.wxPoint, pcbnew.EDA_RECT))
#                                                               ^^^^^^^^^^^^^^^
# AttributeError: module 'pcbnewTransition.pcbnew' has no attribute 'EDA_RECT'
ok 39 Present a single board # skip PcbDraw is not available, skipping
ok 40 Steel stencils
ok 41 Steel stencils with cutout
ok 42 Printed stencils
make: *** [Makefile:40: test-system] Error 1

I see this is fixed upstream in yaqwsx/KiKit@c920ba3, which was released just 16 hours ago in kikit 1.5.0. Looking at the ryantm update logs, I think it just hasn't realized there's a new version of kikit yet: https://r.ryantm.com/log/kikit/ (the last run was 3 days ago on 2024-02-23). I did try upgrading locally, and I see a new test failure, though. If it's ok, I'd like to wait a day to see if the update bot sends in an update PR (I'm a quite new maintainer of nixpkgs and would like to learn how to fix a broken auto-update PR).

evils · 2024-02-27T03:33:36Z

i don't believe the bot submits PRs if the package fails to build :)

jfly · 2024-02-27T03:37:51Z

Ah, OK. How am I as a maintainer supposed to know that happened so I can intervene?

evils · 2024-02-27T03:48:38Z

good question, i don't believe it emits such indications
i suppose that's in part to avoid spamming people

one thing you can do is run this script once in a while
nix-shell maintainers/scripts/update.nix --argstr maintainer jfly
i don't think that's nearly as extensive as what the bot does
it does seem to get everything you maintain minus kikit/solidpython

jfly · 2024-02-27T04:37:16Z

Gotcha. That's a bummer, I thought I just had to look at my email to keep things up to date.

For the record, I've created #291734 to get kikit upgraded. If we can get that merged first, then there shouldn't be a window of time in master where kikit is broken.

This includes support for KiCad 8 (see complete changelog [here](https://github.com/yaqwsx/KiKit/releases/tag/v1.5.0)), which should unblock NixOS#291134. With this upgrade, a test started failing: $ nix build .#kikit ... kikit> not ok 40 Steel stencils kikit> # (in test file /build/source/test/system/stencil.bats, line 6) kikit> # `kikit stencil create --jigsize 60 60 $RES/conn.kicad_pcb steelStencil' failed kikit> # 04:32:16: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied) kikit> # An error occurred: OpenSCAD is not available. kikit> # Did you install it? Program `openscad` has to be in PATH kikit> # No output files produced kikit> not ok 41 Steel stencils with cutout kikit> # (in test file /build/source/test/system/stencil.bats, line 10) kikit> # `kikit stencil create --jigsize 60 60 --cutout J4 $RES/conn.kicad_pcb steelStencil' failed kikit> # 04:32:17: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied) kikit> # An error occurred: OpenSCAD is not available. kikit> # Did you install it? Program `openscad` has to be in PATH kikit> # No output files produced kikit> not ok 42 Printed stencils kikit> # (in test file /build/source/test/system/stencil.bats, line 14) kikit> # `kikit stencil createprinted \' failed kikit> # 04:32:17: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied) kikit> # An error occurred: OpenSCAD is not available. kikit> # Did you install it? Program `openscad` has to be in PATH kikit> # No output files produced kikit> make: *** [Makefile:40: test-system] Error 1 kikit> /nix/store/3qnm3nwjajgqa771dmi2dnwxrw0kzq5m-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context error: builder for '/nix/store/f3klmz0qvi6yr3qfy7cww434f2z4kjx5-kikit-1.5.0.drv' failed with exit code 2; This is failing in some pretty old kikit code, so I think this is just failing due to kikit now having more complete code coverage. While researching this, I discovered kikit's documentation about [optional dependencies], which I suppose we don't have good support for right now. Rather than invent a new option for that, I've opted to preserve the existing behavior and just do the bare minimum to keep the build passing. [optional dependencies]: https://github.com/yaqwsx/KiKit/blob/v1.5.0/docs/installation/intro.md#optional-dependencies

evils · 2024-03-13T20:51:39Z

just a note in case anyone was holding off on reviewing or merging this
the kikit PR was merged, so it's no longer blocking this one

jfly

Code LGTM, but I still can't successfully test out kikit on this branch because it doesn't have the latest changes from master.

I tried checking out this PR locally and rebasing on top of the latest in master and got a conflict in pkgs/development/libraries/log4cplus/default.nix that I'm stumped by.

kirillrdy · 2024-03-13T22:37:16Z

@jfly if you run nixpkgs-review pr 291134

it will build you a merge of master and this PR

jfly · 2024-03-14T02:43:34Z

Thanks, @kirillrdy. I just manually tested out kikit with this PR, and things seem to work!

kirillrdy · 2024-03-14T20:31:34Z

Result of nixpkgs-review pr 291134 run on x86_64-linux 1

3 packages failed to build:

python312Packages.kicad
python312Packages.pcbnew-transition
python312Packages.pcbnew-transition.dist

13 packages built:

kicad
kicad-small
kicad-testing
kicad-testing-small
kicad-unstable
kicad-unstable-small
kicadAddons.kikit
kicadAddons.kikit-library
kikit
kikit.dist
python311Packages.kicad
python311Packages.pcbnew-transition
python311Packages.pcbnew-transition.dist

3.12 build fails because of diffimg which also fails on master

evils · 2024-03-16T02:36:30Z

oh, i maintain diffimg -_-

kiranshila · 2024-03-16T19:25:45Z

Perhaps this PR can also cover the recent bugfix release as well? https://www.kicad.org/blog/2024/03/KiCad-8.0.1-Release/

evils · 2024-03-17T08:10:49Z

pushed 8.0.1

kirillrdy · 2024-03-17T19:19:39Z

Result of nixpkgs-review pr 291134 run on aarch64-linux 1

16 packages failed to build:

kicad
kicad-small
kicad-testing
kicad-testing-small
kicad-unstable
kicad-unstable-small
kicadAddons.kikit
kicadAddons.kikit-library
kikit
kikit.dist
python311Packages.kicad
python311Packages.pcbnew-transition
python311Packages.pcbnew-transition.dist
python312Packages.kicad
python312Packages.pcbnew-transition
python312Packages.pcbnew-transition.dist

evils · 2024-03-19T09:25:00Z

8.0.0 also fails on aarch64
7.0.10 doesn't have the qa_cli test that's failing
checking the -unstable package now

evils · 2024-03-19T13:03:31Z

it doesn't appear as if aarch64-linux is supported by upstream
not sure how best to reflect this in the package here
i'm inclined to skip the qa_cli test for aarch64-linux and hope that if there is an issue with the actual app a Nix user reports the issue to nixpkgs
(i have an aarch64 VPS available, but nothing i can practically check the GUI on)

lukaslihotzki · 2024-03-19T16:16:04Z

I can confirm that the Kicad (both 8.0.1 and testing 2024-03-16) GUI works fine on aarch64 NixOS. I disabled the tests completely (doInstallCheck = false;). Although this should be independent of qa_cli which checks the kicad-cli CLI tool.

Additionally, I get this build error when doing nixpkgs-review pr 291134: ModuleNotFoundError: No module named 'distutils' when building python3.12-wxpython-4.2.1.

lukaslihotzki · 2024-03-20T17:04:42Z

The qa_cli test fails because of some image differences and because the items in the orcadpcb2 output are unexpectedly reordered. So, the item ordering of orcadpcb2 (which is determined by an rtree) seems to be architecture-specific. I don't know if this is a bug in rtree or if the test is too strict, but this test fail should be harmless otherwise. I haven't looked at the image differences yet.

disables failing qa_spice test suite for unstable upstream seems aware, have not reported it though

switch to KICAD8 env vars make the previously unstable dependencies stable reenable the qa_eeschema test and disable qa_spice also bump testing and unstable

evils · 2024-03-20T20:12:01Z

i've added disabling the qa_cli test on aarch64-linux

kirillrdy · 2024-03-22T09:13:00Z

@evils thank you for PR
feel free to tag me for any fallout

evils · 2024-03-24T10:08:07Z

note for completeness: someone from upstream successfully ran the qa_cli test on ubuntu on aarch64
but confirmed it's not an officially supported platform

evils mentioned this pull request Feb 24, 2024

kicad: 7.0.10 -> 7.0.11 #290596

Closed

13 tasks

bgamari reviewed Feb 24, 2024

View reviewed changes

Comment thread pkgs/applications/science/electronics/kicad/base.nix

evils force-pushed the kicad-8 branch from f355d2c to e70e137 Compare February 26, 2024 16:53

jfly reviewed Feb 27, 2024

View reviewed changes

jfly mentioned this pull request Feb 27, 2024

kikit: 1.4.0 -> 1.5.0 #291734

Merged

13 tasks

jfly approved these changes Mar 13, 2024

View reviewed changes

evils mentioned this pull request Mar 16, 2024

python312Packages.diffimg: fix test #296323

Merged

13 tasks

evils force-pushed the kicad-8 branch from e70e137 to 8f763ab Compare March 17, 2024 08:10

evils changed the title ~~kicad: 7.0.10 -> 8.0.0~~ kicad: 7.0.10 -> 8.0.1 Mar 17, 2024

evils added 5 commits March 20, 2024 21:09

kicad: 7.0.10 -> 7.0.11

746bcfb

kicad-unstable: 2023-08-15 -> 2024-02-07

b18493e

disables failing qa_spice test suite for unstable upstream seems aware, have not reported it though

kicad: 7.0.11 -> 8.0.0

55e0055

switch to KICAD8 env vars make the previously unstable dependencies stable reenable the qa_eeschema test and disable qa_spice also bump testing and unstable

kicad: 8.0.0 -> 8.0.1

ec2fe6b

kicad: also disable qa_cli on aarch64-linux

9d285ec

evils force-pushed the kicad-8 branch from 8f763ab to 9d285ec Compare March 20, 2024 20:10

kirillrdy merged commit 97c86a7 into NixOS:master Mar 22, 2024

Uh oh!

Conversation

evils commented Feb 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

evils commented Feb 24, 2024

Uh oh!

Uh oh!

bgamari commented Feb 24, 2024

Uh oh!

evils commented Feb 24, 2024

Uh oh!

evils commented Feb 24, 2024

Uh oh!

evils commented Feb 24, 2024

Uh oh!

jfly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evils commented Feb 27, 2024

Uh oh!

jfly commented Feb 27, 2024

Uh oh!

evils commented Feb 27, 2024

Uh oh!

jfly commented Feb 27, 2024

Uh oh!

evils commented Mar 13, 2024

Uh oh!

jfly left a comment

Choose a reason for hiding this comment

Uh oh!

kirillrdy commented Mar 13, 2024

Uh oh!

jfly commented Mar 14, 2024

Uh oh!

kirillrdy commented Mar 14, 2024

Uh oh!

evils commented Mar 16, 2024

Uh oh!

kiranshila commented Mar 16, 2024

Uh oh!

evils commented Mar 17, 2024

Uh oh!

kirillrdy commented Mar 17, 2024

Uh oh!

evils commented Mar 19, 2024

Uh oh!

evils commented Mar 19, 2024

Uh oh!

lukaslihotzki commented Mar 19, 2024

Uh oh!

lukaslihotzki commented Mar 20, 2024

Uh oh!

evils commented Mar 20, 2024

Uh oh!

kirillrdy commented Mar 22, 2024

Uh oh!

evils commented Mar 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

evils commented Feb 24, 2024 •

edited

Loading

jfly left a comment •

edited

Loading