Conversation
Contributor
|
cc @smartalecH and @romanodev — it would be good to add this to the Python API too. |
Collaborator
|
I have a draft for the python implementation locally -- I'll try to push something soon. |
Contributor
|
Note that this is the algorithm from NanoComp/meep#3087 (comment), which I assume is the same as @smartalecH's draft. Any comments on the API? A |
stevengj
reviewed
Jun 26, 2026
| @@ -177,6 +179,7 @@ function smoothed_projection(rho_filtered, rho_filtered_derivs_normsq, R_smoothi | |||
| nonzero_norm = abs(den_helper) > zero(den_helper) | |||
Contributor
There was a problem hiding this comment.
Unrelated comment: why isn't this just !iszero(den_helper)?
Collaborator
|
The API is straightforward. @smartalecH: if your draft is different than the intended approach, I can take a crack at this (or feel free to address only SSP1, and I will follow with SSP2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
dilation_distancekeyword to theProjectionProblemAPI in the Julia API that provides an easy way to expand the solid region by approximatelydilation_distancein all directions (or shrink/erode it ifdilation_distanceis negative).Additionally, in the high-level api, the functions
ssp1,ssp1_linear, andssp2accept an optional trailing positional argument for thedilation_distance.Tests were added for the adjoints w.r.t. the filtered density in the presence of a non-zero dilation for both the low-level and high-level APIs.
Additionally, I added an example that demonstrates the effect of the dilation/erosion on Cassini ovals.