This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Add CUB block and device merge sort#322
Merged
gevtushenko merged 1 commit intoJul 28, 2021
Merged
Conversation
0f8b8cc to
ee4f5bb
Compare
ee4f5bb to
d5e3402
Compare
alliepiper
suggested changes
Jun 17, 2021
alliepiper
left a comment
Collaborator
There was a problem hiding this comment.
This looks good overall. I have some comments about style and docs mostly -- I think most of the style issues come from the Thrust implementation, but let's clean some of them up while porting.
9ec947c to
f175b97
Compare
f175b97 to
334c546
Compare
alliepiper
reviewed
Jul 2, 2021
alliepiper
left a comment
Collaborator
There was a problem hiding this comment.
The rewritten sections are /much/ easier to follow now, nice job! 👍
A few minor changes to docs/style suggested inline. Once those are addressed this should be ready to test.
alliepiper
reviewed
Jul 2, 2021
334c546 to
590ddee
Compare
590ddee to
f6d6db6
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jul 7, 2021
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jul 7, 2021
f6d6db6 to
764ca4b
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jul 7, 2021
764ca4b to
c4af0d1
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jul 8, 2021
alliepiper
approved these changes
Jul 21, 2021
alliepiper
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, approving. This will need to be rebased and updated to use the new CUB_NAMESPACE_BEGIN and CUB_NAMESPACE_END macros, then retested on gpuCI and DVS.
c4af0d1 to
9631ad6
Compare
Collaborator
Author
|
DVS: 30226396 |
9631ad6 to
267d78f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a port of thrust merge sort algorithm, which was split into device and block parts.