Skip to content

ci: add mkdir step for mypy - #1

Closed
MichaelCurrin wants to merge 2 commits into
masterfrom
ci-add-mypy-cache-dir-to-workflow
Closed

MichaelCurrin wants to merge 2 commits into
masterfrom
ci-add-mypy-cache-dir-to-workflow

Conversation

@MichaelCurrin

Copy link
Copy Markdown
Owner

Describe your change:

When running with no cache the first time, mypy fails to get missing imports because the cache is missing.

An empty cache solves the issue.

TheAlgorithms#5917 (comment)

  • Fix CI flow for new contributors
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@MichaelCurrin
MichaelCurrin deleted the ci-add-mypy-cache-dir-to-workflow branch January 26, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant