Repository navigation
Document how to change the padding inside a text message bubble - #1931
Open
martinpucik wants to merge 1 commit into
Open
martinpucik wants to merge 1 commit into
martinpucik wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kdtqz8QWNhVD6H5FsRa4wy
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds a FAQ entry on changing the space between the text and the edge of a text message bubble.
incomingMessageLabelInsetsandoutgoingMessageLabelInsetsonTextMessageSizeCalculator. The calculator adds them to the text size and passes them toTextMessageCellthroughmessageLabelInsets.MessagesCollectionViewFlowLayouthas separate calculators for.text,.attributedTextand.emoji, so the example sets the insets on all three.setMessageIncoming/OutgoingMessagePadding(_:), which sets the space outside the bubble.textCellSizeCalculator(for:at:in:). It also says why creating a calculator on every call and changing the layout'sitemSize(what the issue tried) has no effect: cells are sized by the calculator throughsizeForItem(at:), not byitemSize.It also adds the missing contents link for the existing "Why is
didTapMessage(in:)not called when I tap a photo or video message?" entry, and a CHANGELOG line.Does this close any currently open issues?
Answers #1811.
Any relevant logs, error output, etc?
None.
Any other comments?
This changes documentation only. I checked the default inset values, the calculator properties and the delegate signatures against
Sources/Layout/TextMessageSizeCalculator.swift,MessagesCollectionViewFlowLayout.swiftandMessagesLayoutDelegate.swift.Where has this been tested?
Devices/Simulators: N/A (documentation only)
iOS Version: N/A
Swift Version: N/A
MessageKit Version: main
Generated by Claude Code