Repository navigation
Autotests for navbar buttons. - #4982
Draft
Elena Kurakina (solarday) wants to merge 1 commit into
Draft
Elena Kurakina (solarday) wants to merge 1 commit into
Elena Kurakina (solarday) wants to merge 1 commit into
Conversation
Elena Kurakina (solarday)
requested review from
Yuri Teplyakov (krutilov),
Nikolai Pachkov (nikpachoo) and
Konstantin Chernenko (zoobestik)
as code owners
July 29, 2025 15:15
Nikolai Pachkov (nikpachoo)
requested changes
Jul 30, 2025
| @@ -0,0 +1,70 @@ | |||
| import { test, expect } from '@playwright/test'; | |||
|
|
|||
| test.describe('Navbar buttons', () => { | |||
Collaborator
There was a problem hiding this comment.
I suggest renaming the test: this part of navigation we call "header".
Also, there is a test in the master branch, api navigation. What do you think about unifying them into one file and calling it header.spec.ts? I would expect to have all the header tests related to it in one place.
| }); | ||
|
|
||
| test('Kotlin logo opens the homepage', async ({ page }) => { | ||
| const kotlinLogo = page.locator('.ktl-logo-large-module_link_AOGas'); |
Collaborator
There was a problem hiding this comment.
The locators should be change to not use classes and especially classes with hashes like "_AOGas". They may change after an update, and we'll be forced to update the tests.
My suggestion: we need to add data-testid for the header elements.
Nikolai Pachkov (nikpachoo)
marked this pull request as draft
August 6, 2025 14:16
Collaborator
|
Elena Kurakina (@solarday), i changed the status of PR, until we add the data-selectors to the head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.