Repository navigation
Conversation
There was a problem hiding this comment.
Many changes that were made in these commits throughout HydraEntrypoint class are not compatible with develop branch of hydrus. I have tested both hydrus and core repo locally in same virtual environment and I don't think we should merge these as it will result in the failure of tests in hydrus. Still needs many changes.
@sameshl Can you please confirm ?
@Mec-iS Should we split this one big PR into multiple PRs ?
| collection_returned = item.generate() | ||
| collection_id = uri.replace( | ||
| "{}EntryPoint".format(DocUrl.doc_url), "{}{}".format(self.url,self.api)) | ||
| collection_id = uri |
There was a problem hiding this comment.
Some changes that were made in HydraEntrypoint class in previous commits are resulting in breakage.
| else: | ||
| self.id_ = "{}EntryPoint/{}".format(DocUrl.doc_url, quote(self.name, safe='')) | ||
| self.id_ = "{}EntryPoint/{}".format( | ||
| DocUrl.doc_url, quote(collection.path, safe="") |
There was a problem hiding this comment.
if collection.path isn't available self.name should be used.
|
thanks for looking into this. |
|
Yes these commits were to be added to core before merging #518 in hydrus. I had mentioned that in the review too. Let's merge these ASAP so hydrus builds don't fail. |
|
@farazkhanfk7 Can you finish the remaining part of this PR so we merge it? |
|
Yes. I'll do it today itself. Was facing an issue in pep8 tests. I've added a question on slack about it. |
|
Changes applied in #81 |
See #61