Skip to content

Link formatting - #79

Closed
Mec-iS wants to merge 8 commits into
developfrom
link_format
Closed

Mec-iS wants to merge 8 commits into
developfrom
link_format

Conversation

@Mec-iS

@Mec-iS Mec-iS commented May 24, 2021 •

Copy link
Copy Markdown
Contributor

See #61

@Mec-iS
Mec-iS requested a review from farazkhanfk7 May 24, 2021 16:30
@Mec-iS Mec-iS mentioned this pull request May 24, 2021
2 tasks done

@farazkhanfk7 farazkhanfk7 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes that were made in these commits throughout HydraEntrypoint class are not compatible with develop branch of hydrus. I have tested both hydrus and core repo locally in same virtual environment and I don't think we should merge these as it will result in the failure of tests in hydrus. Still needs many changes.

@sameshl Can you please confirm ?
@Mec-iS Should we split this one big PR into multiple PRs ?

collection_returned = item.generate()
collection_id = uri.replace(
"{}EntryPoint".format(DocUrl.doc_url), "{}{}".format(self.url,self.api))
collection_id = uri

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes that were made in HydraEntrypoint class in previous commits are resulting in breakage.

else:
self.id_ = "{}EntryPoint/{}".format(DocUrl.doc_url, quote(self.name, safe=''))
self.id_ = "{}EntryPoint/{}".format(
DocUrl.doc_url, quote(collection.path, safe="")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if collection.path isn't available self.name should be used.

@Mec-iS

Mec-iS commented May 24, 2021

Copy link
Copy Markdown
Contributor Author

thanks for looking into this.
Please proceed as you see fit, I will follow.

@chrizandr

Copy link
Copy Markdown
Member

Yes these commits were to be added to core before merging #518 in hydrus. I had mentioned that in the review too. Let's merge these ASAP so hydrus builds don't fail.

@sameshl

sameshl commented May 28, 2021

Copy link
Copy Markdown
Member

@farazkhanfk7 Can you finish the remaining part of this PR so we merge it?

@farazkhanfk7

farazkhanfk7 commented May 28, 2021 •

Copy link
Copy Markdown
Member

Yes. I'll do it today itself. Was facing an issue in pep8 tests. I've added a question on slack about it.

@Mec-iS

Mec-iS commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

Changes applied in #81

@Mec-iS Mec-iS closed this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants