Cloning v1beta3 as v1 and exposing it in the apiserver#7454
Merged
Conversation
Contributor
Author
|
cc @bgrant0607 |
Member
There was a problem hiding this comment.
We shouldn't enable v1 by default.
Member
There was a problem hiding this comment.
Why do we need all these conversions? I'd expect the internal rep to be very close to the v1 API.
Contributor
There was a problem hiding this comment.
It's an optimization that @wojtek-t is working on. They're auto-generated.
Member
Contributor
|
Looks OK, unfortunate that everything has to be done in four places now... |
Member
|
Hopefully we can get rid of v1beta1/2 in a couple weeks, which should help a lot. |
Member
|
LGTM. Will merge on green. We can fix anything necessary, like removing minions, in subsequent, smaller PRs. |
Member
|
Both travis and shippable are very backed up, so it may be a while. |
Contributor
Author
|
Yes. Right now, this is just an "as-is" copy of v1beta3. |
Contributor
Author
|
Shippable is green!! |
bgrant0607
added a commit
that referenced
this pull request
Apr 29, 2015
Cloning v1beta3 as v1 and exposing it in the apiserver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #7018