Fix canary test goconst lint (#193)

YoungJinJung · web-flow · commit dda3d7f67f65 · 2026-06-29T10:17:41.000+09:00
diff --git a/pkg/deployer/canary_test.go b/pkg/deployer/canary_test.go
@@ -29,6 +29,8 @@ import (
 	"github.com/DevopsArtFactory/goployer/pkg/schemas"
 )
 
+const testCanaryASGName = "demo-canary-v002"
+
 func TestCheckCanaryVersion(t *testing.T) {
 	region := constants.DefaultRegion
 	regionShard := strings.ReplaceAll(region, "-", "")
@@ -127,12 +129,12 @@ func TestShouldRollbackCanary(t *testing.T) {
 func TestCanaryAutoScalingGroupNamePrefersActiveDeployment(t *testing.T) {
 	c := Canary{
 		Deployer: &Deployer{
-			AsgNames:  map[string]string{constants.DefaultRegion: "demo-canary-v002"},
+			AsgNames:  map[string]string{constants.DefaultRegion: testCanaryASGName},
 			LatestAsg: map[string]string{constants.DefaultRegion: "demo-stable-v001"},
 		},
 	}
 
-	if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != "demo-canary-v002" {
+	if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != testCanaryASGName {
 		t.Fatalf("expected active canary ASG, got %s", got)
 	}
 }
@@ -141,23 +143,23 @@ func TestCanaryAutoScalingGroupNameFallsBackToLatestWithEmptyActiveMap(t *testin
 	c := Canary{
 		Deployer: &Deployer{
 			AsgNames:  map[string]string{},
-			LatestAsg: map[string]string{constants.DefaultRegion: "demo-canary-v002"},
+			LatestAsg: map[string]string{constants.DefaultRegion: testCanaryASGName},
 		},
 	}
 
-	if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != "demo-canary-v002" {
+	if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != testCanaryASGName {
 		t.Fatalf("expected latest ASG fallback, got %s", got)
 	}
 }
 
 func TestCanaryAutoScalingGroupNameFallsBackToLatestWithNilActiveMap(t *testing.T) {
 	c := Canary{
 		Deployer: &Deployer{
-			LatestAsg: map[string]string{constants.DefaultRegion: "demo-canary-v002"},
+			LatestAsg: map[string]string{constants.DefaultRegion: testCanaryASGName},
 		},
 	}
 
-	if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != "demo-canary-v002" {
+	if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != testCanaryASGName {
 		t.Fatalf("expected latest ASG fallback, got %s", got)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,8 @@ import (`
`29`	`29`	`"github.com/DevopsArtFactory/goployer/pkg/schemas"`
`30`	`30`	`)`
`31`	`31`
	`32`	`+const testCanaryASGName = "demo-canary-v002"`
	`33`	`+`
`32`	`34`	`func TestCheckCanaryVersion(t *testing.T) {`
`33`	`35`	`region := constants.DefaultRegion`
`34`	`36`	`regionShard := strings.ReplaceAll(region, "-", "")`
`@@ -127,12 +129,12 @@ func TestShouldRollbackCanary(t *testing.T) {`
`127`	`129`	`func TestCanaryAutoScalingGroupNamePrefersActiveDeployment(t *testing.T) {`
`128`	`130`	`c := Canary{`
`129`	`131`	`Deployer: &Deployer{`
`130`		`- AsgNames: map[string]string{constants.DefaultRegion: "demo-canary-v002"},`
	`132`	`+ AsgNames: map[string]string{constants.DefaultRegion: testCanaryASGName},`
`131`	`133`	`LatestAsg: map[string]string{constants.DefaultRegion: "demo-stable-v001"},`
`132`	`134`	`},`
`133`	`135`	`}`
`134`	`136`
`135`		`- if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != "demo-canary-v002" {`
	`137`	`+ if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != testCanaryASGName {`
`136`	`138`	`t.Fatalf("expected active canary ASG, got %s", got)`
`137`	`139`	`}`
`138`	`140`	`}`
`@@ -141,23 +143,23 @@ func TestCanaryAutoScalingGroupNameFallsBackToLatestWithEmptyActiveMap(t *testin`
`141`	`143`	`c := Canary{`
`142`	`144`	`Deployer: &Deployer{`
`143`	`145`	`AsgNames: map[string]string{},`
`144`		`- LatestAsg: map[string]string{constants.DefaultRegion: "demo-canary-v002"},`
	`146`	`+ LatestAsg: map[string]string{constants.DefaultRegion: testCanaryASGName},`
`145`	`147`	`},`
`146`	`148`	`}`
`147`	`149`
`148`		`- if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != "demo-canary-v002" {`
	`150`	`+ if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != testCanaryASGName {`
`149`	`151`	`t.Fatalf("expected latest ASG fallback, got %s", got)`
`150`	`152`	`}`
`151`	`153`	`}`
`152`	`154`
`153`	`155`	`func TestCanaryAutoScalingGroupNameFallsBackToLatestWithNilActiveMap(t *testing.T) {`
`154`	`156`	`c := Canary{`
`155`	`157`	`Deployer: &Deployer{`
`156`		`- LatestAsg: map[string]string{constants.DefaultRegion: "demo-canary-v002"},`
	`158`	`+ LatestAsg: map[string]string{constants.DefaultRegion: testCanaryASGName},`
`157`	`159`	`},`
`158`	`160`	`}`
`159`	`161`
`160`		`- if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != "demo-canary-v002" {`
	`162`	`+ if got := c.CanaryAutoScalingGroupName(constants.DefaultRegion); got != testCanaryASGName {`
`161`	`163`	`t.Fatalf("expected latest ASG fallback, got %s", got)`
`162`	`164`	`}`
`163`	`165`	`}`