Repository navigation
ci: replace the cached SPC buildroot instead of copying into it - #302
Merged
Merged
Conversation
`cp -a buildroot spc-cache/buildroot` onto a directory restored from an older cache nests the new build inside it, so the saved cache kept the old runtime at its top level, without the recorded PHP version. A later exact hit then reused that old runtime. Remove the restored copy first. Affects the binary check and the release dry run; the release build does not cache its runtime. Build tooling only: MySQL, PostgreSQL and SQLite behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The binary check's cache step copied the new buildroot onto the one restored from an older cache with
cp -a buildroot spc-cache/buildroot. When the destination already exists,cpputs the copy inside it, atspc-cache/buildroot/buildroot. The saved cache therefore kept the older runtime at its top level, withoutphp-version.txt.The next run with an exact cache hit reused that older runtime. The PHP-version check added in #299 caught this and failed:
the binary was built from PHP 'unknown', not 8.3.36.The fix removes the restored copy before saving, in both
binary-check.ymlandrelease-dry-run.yml. Editing the workflow also changes its cache key, so the next run rebuilds once and saves a clean cache.This changes build tooling only. MySQL, PostgreSQL and SQLite behaviour is unchanged.
🤖 Generated with Claude Code