Skip to content

ci: replace the cached SPC buildroot instead of copying into it - #302

Merged
jasdeepkhalsa merged 1 commit into
masterfrom
ci/spc-cache-overwrite
Nov 14, 2026
Merged

jasdeepkhalsa merged 1 commit into
masterfrom
ci/spc-cache-overwrite

Conversation

@jasdeepkhalsa

Copy link
Copy Markdown
Member

The binary check's cache step copied the new buildroot onto the one restored from an older cache with cp -a buildroot spc-cache/buildroot. When the destination already exists, cp puts the copy inside it, at spc-cache/buildroot/buildroot. The saved cache therefore kept the older runtime at its top level, without php-version.txt.

The next run with an exact cache hit reused that older runtime. The PHP-version check added in #299 caught this and failed: the binary was built from PHP 'unknown', not 8.3.36.

The fix removes the restored copy before saving, in both binary-check.yml and release-dry-run.yml. Editing the workflow also changes its cache key, so the next run rebuilds once and saves a clean cache.

This changes build tooling only. MySQL, PostgreSQL and SQLite behaviour is unchanged.

🤖 Generated with Claude Code

`cp -a buildroot spc-cache/buildroot` onto a directory restored from an
older cache nests the new build inside it, so the saved cache kept the
old runtime at its top level, without the recorded PHP version. A later
exact hit then reused that old runtime. Remove the restored copy first.
Affects the binary check and the release dry run; the release build does
not cache its runtime. Build tooling only: MySQL, PostgreSQL and SQLite
behaviour is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@github-actions github-actions Bot added bug mysql Related to Mysql postgres Related to Postgres sqlite Related to Sqlite labels Nov 13, 2026
@jasdeepkhalsa
jasdeepkhalsa merged commit bf14bcd into master Nov 14, 2026
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug mysql Related to Mysql postgres Related to Postgres sqlite Related to Sqlite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant