Skip to content

test(quality): expand feature validation coverage #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidBabinec merged 10 commits into from
Jun 26, 2026
Merged

test(quality): expand feature validation coverage #84

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c7281e9
test(quality): expand feature validation coverage
DavidBabinec Jun 23, 2026
ef7155b
fix(settings): contain preferences modal on mobile
DavidBabinec Jun 23, 2026
10eb2e8
test(users): cover non-owner lifecycle validation
DavidBabinec Jun 23, 2026
af6d516
test(admin): cover global toolbar live targets
DavidBabinec Jun 23, 2026
4dd3abc
fix(admin): harden workspace shell recovery
DavidBabinec Jun 23, 2026
896bf79
fix(admin): contain right sidebar on mobile
DavidBabinec Jun 23, 2026
7fd476f
test(server): clarify audit SQL null bindings
DavidBabinec Jun 24, 2026
e2fd7b6
test(quality): clear code quality blockers
DavidBabinec Jun 24, 2026
ecc347d
test(quality): avoid CodeQL step-up false positive
DavidBabinec Jun 24, 2026
26da03a
test(quality): resolve feature validation rebase drift
DavidBabinec Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(admin): cover global toolbar live targets
  • Loading branch information
@DavidBabinec
DavidBabinec committed Jun 26, 2026
commit af6d5161dee2ea90b3451703ff62874ee216e784
4 changes: 2 additions & 2 deletions docs/e2e/feature-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ PUBLISH-002 note: `page-management.e2e.ts` schedules a newly-created active page
|---|---:|:---:|---|---|---|---|---|---|
| ADMIN-001 | P1 | ✅ | Navigation | Move between Site, Content, Plugins, Users, Account | Logged in | Admin navigation | Active page and breadcrumbs are clear | dead links, unclear active state |
| ADMIN-002 | P2 | partial | Account | Change account profile basics | Logged in | Account page | Step-up prompt appears; changes save and persist | missing feedback, validation copy |
| ADMIN-003 | P2 | partial | Admin shell | Use global toolbar actions and account menu | Logged in | Top toolbar from each workspace | Workspace links, Settings, account menu, and publish/open-live actions appear when allowed | stale active route, clipped toolbar, unavailable settings/account actions |
| ADMIN-003 | P2 | ✅ | Admin shell | Use global toolbar actions and account menu | Logged in | Top toolbar from each workspace | Workspace links, Settings, account menu, and publish/open-live actions appear when allowed | stale active route, clipped toolbar, unavailable settings/account actions |
| ADMIN-004 | P2 | ✅ | Settings | Manage global settings and local editor preferences | Logged in | Toolbar Settings from Dashboard and narrow viewport | General, Shortcuts, Publishing, and Preferences render; preference changes persist locally; corrupt storage falls back; mobile layout stays contained | site-settings load errors, corrupt localStorage, clipped controls |
| ACCOUNT-003 | P2 | partial | Security | Change account password and verify old credentials stop working | Logged in | Account security plus login | Form validation is specific; password change requires step-up; old password is rejected and new password works | shared credential restoration, other-session revocation, autocomplete |
| AUTH-002 | P1 | partial | Auth | Complete MFA challenge after password login | MFA enabled owner | Login, enter authenticator or recovery code | Session reaches admin; recovery-code login consumes one code | pending-session escalation |
Expand All @@ -58,7 +58,7 @@ PUBLISH-002 note: `page-management.e2e.ts` schedules a newly-created active page

ADMIN-002 note: display-name editing and mobile step-up cancel/no-op are automated with the step-up prompt (canonical spreadsheet row ACCOUNT-001), and `/me` profile API edges cover step-up denial, trimmed email save, the 160-character display-name boundary, invalid payloads, and duplicate normalized email rejection in `src/__tests__/server/accountSecurity.test.ts`. Avatar upload/removal plus unsupported, oversized, and mobile layout avatar feedback are automated (canonical spreadsheet row ACCOUNT-002) in `account.e2e.ts`; empty multipart upload, idempotent missing-avatar removal, and elected storage-adapter failure are covered in `src/__tests__/server/accountSecurity.test.ts`. Browser email editing uses the same step-up-gated Profile form but stays lower-level/API-covered so the shared owner login email remains stable during the E2E suite.

ADMIN-003 note: workspace navigation and account-menu logout/login are covered by the core owner lifecycle and `auth.e2e.ts`; toolbar Settings coverage is promoted under ADMIN-004.
ADMIN-003 note: `admin-navigation.e2e.ts` now verifies the global toolbar trailer on Dashboard, account menu actions, Open Live root fallback, Content selected-entry deep-linking to `/posts/<slug>`, clearing the entry target after leaving Content, and 390px toolbar-trailer containment. Workspace navigation is covered in the same file, account-menu logout/session invalidation is covered by the core owner lifecycle and `auth.e2e.ts`, Settings behavior is covered under ADMIN-004, and publish affordances are exercised by publish/content specs.

ADMIN-004 note: `admin-navigation.e2e.ts` opens Settings from the Dashboard non-editor route, verifies General, Shortcuts, Publishing, and Preferences sections, writes Auto-save, Auto-save delay, and UI density through real controls, verifies reload persistence, verifies corrupt localStorage fallback, and checks 390px containment. DEF-20260623-ADMIN004-01 fixed a phone-width overflow where Preferences controls extended beyond the viewport; `SettingsModal.module.css` now switches to a single-column mobile shell with stacked preference rows.

Expand Down
Loading