Skip to content

test(quality): expand feature validation coverage#84

Merged
DavidBabinec merged 10 commits into
mainfrom
test/feature-validation-coverage
Jun 26, 2026
Merged

test(quality): expand feature validation coverage#84
DavidBabinec merged 10 commits into
mainfrom
test/feature-validation-coverage

Conversation

@DavidBabinec

@DavidBabinec DavidBabinec commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expanded ADMIN-005 shell reliability coverage in the canonical feature matrix and TSV spreadsheet.
  • Added ToastProvider regressions for alert/status aria behavior, metadata, and dismiss cleanup through the canonical Toast barrel.
  • Exported dismissToast from @ui/components/Toast to match the toast bus API used by producers/tests.
  • Added browser regressions for Content workspace panel resize, close/reopen, reload persistence, and 390px mobile containment.
  • Capped the rendered left sidebar width on narrow viewports while preserving the stored desktop panel width.
  • Capped and mobile-anchored the right sidebar so the Settings close control stays reachable when both sidebars reopen on a phone viewport.

Defects

  • DEF-20260623-ADMIN005-01: Toast barrel exported pushToast but not dismissToast, breaking canonical dismiss imports and stale-toast cleanup tests.
  • DEF-20260623-ADMIN005-02: Persisted 520px Content left-panel width could push the close affordance beyond a 390px viewport after reload.
  • DEF-20260623-ADMIN005-03: Persisted Content + Settings sidebars could place the Settings close affordance at x=684 in a 390px viewport after reload.

Impact

ADMIN-005 now has focused unit coverage plus live browser evidence for workspace shell recovery. Remaining risk is documented for injected route-failure exploratory review.

Verification

  • Red focused ADMIN-005 E2E failed on the settings close button at x=684 before the right-sidebar fix.
  • Green focused bun run test:e2e -- --project=e2e tests/e2e/admin-navigation.e2e.ts -g "ADMIN-005" passed 2/2 including setup.
  • bun run test:e2e -- --project=e2e tests/e2e/admin-navigation.e2e.ts passed 5/5.
  • Browser smoke at 390x844 showed both close controls ending at x=384, zero document overflow, no console warnings/errors, and successful Settings close recovery.
  • bun run lint passed.
  • bun run build passed.
  • bun test passed 5703/5703.
  • TSV 14-field validation passed for 146 rows.
  • git diff --check passed.

@DavidBabinec
DavidBabinec changed the base branch from main to fix/spotlight-active-tree-layers June 23, 2026 16:21
Comment thread src/__tests__/server/auditLogEdges.test.ts Fixed
Comment thread src/__tests__/server/auditLogEdges.test.ts Fixed
Comment thread src/__tests__/server/auditLogEdges.test.ts Fixed
Base automatically changed from fix/spotlight-active-tree-layers to main June 24, 2026 11:45
@DavidBabinec
DavidBabinec force-pushed the test/feature-validation-coverage branch from 3885991 to 80b828b Compare June 24, 2026 12:40
Comment thread src/__tests__/server/auditLogEdges.test.ts Fixed
Comment thread src/__tests__/server/auditLogEdges.test.ts Fixed
Comment thread src/__tests__/server/auditLogEdges.test.ts Fixed
Comment thread server/auth/tokens.ts Fixed
@DavidBabinec
DavidBabinec force-pushed the test/feature-validation-coverage branch from 2017a46 to 26da03a Compare June 26, 2026 15:19
@DavidBabinec
DavidBabinec marked this pull request as ready for review June 26, 2026 15:19
@DavidBabinec
DavidBabinec merged commit 80d443a into main Jun 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants