fix(editor): remove redundant publish success callout#278
Draft
DavidBabinec wants to merge 1 commit into
Draft
Conversation
DavidBabinec
force-pushed
the
fix/remove-publish-success-callout
branch
from
July 25, 2026 18:43
01a6b0d to
cf81b0f
Compare
DavidBabinec
force-pushed
the
fix/remove-publish-success-callout
branch
from
July 25, 2026 18:47
cf81b0f to
cd315f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Publishedbutton state as the success confirmationWhy
The page-count callout duplicated the button’s persistent success state and added unnecessary visual noise. Publish failures should use Instatic’s standard operation-error pattern instead of recreating the same anchored popup treatment.
Impact
Successful publishes now transition quietly to the existing checked
Publishedbutton state. Failed publishes retain the inlineRetry publishstate while their detailed error appears in the standard bottom-right toast stack.Verification
bun run lint -- src/admin/pages/site/toolbar/PublishButton.tsx src/admin/pages/site/toolbar/PublishActionGroup.tsxbun run buildgit diff --checkNo regression test was added for this presentation-only cleanup, as requested.