Skip to content

fix(editor): replace hidden layer badge with eye-off icon #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidBabinec merged 1 commit into from
Jul 2, 2026
Merged

fix(editor): replace hidden layer badge with eye-off icon #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(editor): replace hidden layer badge with eye-off icon
  • Loading branch information
@DavidBabinec
DavidBabinec committed Jul 1, 2026
commit 56099c6607ed08e25dc843950285196a726f3283
32 changes: 30 additions & 2 deletions src/__tests__/panels/domPanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { join } from 'path'
import React from 'react'
import { render, screen, cleanup, fireEvent, act, waitFor } from '@testing-library/react'
import { DomPanel } from '@site/panels/DomPanel/DomPanel'
import { LayerTreeNodeContent } from '@site/panels/DomPanel/LayerTreeNodeContent'
import { useEditorStore } from '@site/store/store'
import { makeSite, makePage, makeNode, makeVC, makeVCNode, makeVCTree } from '../fixtures'

Expand Down Expand Up @@ -424,6 +425,32 @@ describe('DomPanel — tree accessibility', () => {
expect(source).toContain('treeDropStyles.dropInvalid')
})

it('hidden layer rows render a muted eye-off icon instead of a text badge', () => {
const { container } = render(
<LayerTreeNodeContent
moduleId="base.container"
displayName="Container"
htmlTag="div"
classSelectorChip={null}
hasChildren={false}
expanded={false}
showIcon={false}
showTag={false}
showClasses={false}
hidden
/>,
)

const hiddenIndicator = container.querySelector('[title="Hidden"]')
expect(hiddenIndicator?.querySelector('svg')).not.toBeNull()
expect(hiddenIndicator?.textContent).toBe('')

const css = readFileSync(TREE_NODE_CSS_PATH, 'utf8')
const hiddenIndicatorBlock = css.match(/\.hiddenIndicator\s*\{[^}]*\}/s)?.[0] ?? ''
expect(hiddenIndicatorBlock).toContain('color: var(--text-muted)')
expect(css).not.toContain('.hiddenBadge')
})

it('drag overlay is portaled outside the transformed panel to keep pointer alignment', () => {
const source = readFileSync(DOM_PANEL_SOURCE_PATH, 'utf8')

Expand Down Expand Up @@ -661,7 +688,7 @@ describe('DomPanel — tree keyboard navigation', () => {
})).toBeDefined()
})

it('keeps hidden nodes in the tree and marks them with a hidden badge', () => {
it('keeps hidden nodes in the tree and marks them with a hidden icon', () => {
loadContainerSite()
act(() => {
useEditorStore.getState().toggleNodeHidden('container-1')
Expand All @@ -670,6 +697,7 @@ describe('DomPanel — tree keyboard navigation', () => {
render(<DomPanel />)

expect(screen.getByRole('treeitem', { name: /container, hidden/i })).toBeDefined()
expect(screen.getByText('hidden')).toBeDefined()
const hiddenIndicator = document.querySelector('[title="Hidden"]')
expect(hiddenIndicator?.querySelector('svg')).not.toBeNull()
})
})
5 changes: 3 additions & 2 deletions src/admin/pages/site/panels/DomPanel/LayerTreeNodeContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { MouseEventHandler, ReactNode } from 'react'
import { EyeOffSolidIcon } from 'pixel-art-icons/icons/eye-off-solid'
import { TreeChevron, TreeIconSlot, TreeLabel, TreeLabelGroup } from '@site/ui/Tree'
import { ModuleIcon } from '@site/ui/ModuleIcon'
import { TagPill } from '@ui/components/TagPill'
Expand Down Expand Up @@ -87,8 +88,8 @@ export function LayerTreeNodeContent({
</span>
)}
{hidden && (
<span aria-hidden="true" className={styles.hiddenBadge}>
hidden
<span title="Hidden" aria-hidden="true" className={styles.hiddenIndicator}>
<EyeOffSolidIcon size={13} color="currentColor" />
</span>
)}
</>
Expand Down
13 changes: 6 additions & 7 deletions src/admin/pages/site/panels/DomPanel/TreeNode.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,13 @@
line-height: 1;
}

.hiddenBadge {
.hiddenIndicator {
flex-shrink: 0;
border-radius: var(--radius-sm);
background: var(--bg-surface-3);
color: var(--text-disabled);
padding: var(--space-px) var(--space-2xs);
font-size: var(--text-2xs);
line-height: 1.3;
display: inline-flex;
align-items: center;
justify-content: center;
color: var(--text-muted);
line-height: 0;
}

/* ── Slot-instance row — dimmer chrome to distinguish structural nodes ───── */
Expand Down