Skip to content

test(canvas): stabilize breakpoint dimming assertion#135

Merged
DavidBabinec merged 1 commit into
mainfrom
fix/breakpoint-dimming-test-flake
Jul 1, 2026
Merged

test(canvas): stabilize breakpoint dimming assertion#135
DavidBabinec merged 1 commit into
mainfrom
fix/breakpoint-dimming-test-flake

Conversation

@DavidBabinec

Copy link
Copy Markdown
Contributor

Summary

  • Wait for the canvas breakpoint frame dimming state to commit before asserting in the breakpoint props test.
  • Re-read frame wrappers after the properties panel is collapsed instead of holding pre-render DOM references.

Why

The v0.0.8 release workflow failed in the Verify job because the breakpoint dimming test asserted synchronously before React had committed the expected data-breakpoint-dimmed state in CI.

Impact

This is a test-only stabilization for the release-blocking canvas breakpoint assertion. Product behavior is unchanged.

Verification

  • bun run build
  • bun test
  • bun run lint

import { describe, expect, it, beforeEach } from 'bun:test'
import React from 'react'
import { act, fireEvent, render, screen, cleanup } from '@testing-library/react'
import { act, fireEvent, render, screen, cleanup, waitFor } from '@testing-library/react'
@DavidBabinec
DavidBabinec marked this pull request as ready for review July 1, 2026 00:50
@DavidBabinec
DavidBabinec merged commit fe9bfbe into main Jul 1, 2026
6 checks passed
@DavidBabinec
DavidBabinec deleted the fix/breakpoint-dimming-test-flake branch July 1, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant