fix(editor): remove redundant publish success callout

DavidBabinec · DavidBabinec · commit cf81b0f61306 · 2026-07-25T20:43:26.000+02:00
diff --git a/src/admin/pages/site/toolbar/PublishActionGroup.tsx b/src/admin/pages/site/toolbar/PublishActionGroup.tsx
@@ -1,4 +1,3 @@
-import { cn } from '@ui/cn'
 import { SplitButton, type SplitButtonMenuItem } from '@ui/components/SplitButton'
 import type { IconComponent } from 'pixel-art-icons/types'
 import styles from './Toolbar.module.css'
@@ -23,10 +22,7 @@ interface PublishActionGroupProps {
   menuItems: PublishActionMenuItem[]
   menuLabel?: string
   triggerLabel?: string
-  toast?: {
-    tone: 'status' | 'alert'
-    message: string
-  } | null
+  errorMessage?: string | null
 }
 
 export function PublishActionGroup({
@@ -44,7 +40,7 @@ export function PublishActionGroup({
   menuItems,
   menuLabel = 'Publishing actions',
   triggerLabel = 'More publishing actions',
-  toast,
+  errorMessage,
 }: PublishActionGroupProps) {
   return (
     <div className={styles.publishActionGroup}>
@@ -83,15 +79,9 @@ export function PublishActionGroup({
           menuTestId="toolbar-publish-actions-menu"
         />
 
-        {toast && (
-          <div
-            role={toast.tone === 'alert' ? 'alert' : 'status'}
-            className={cn(
-              styles.publishToast,
-              toast.tone === 'status' && styles.publishToastStatus,
-            )}
-          >
-            {toast.message}
+        {errorMessage && (
+          <div role="alert" className={styles.publishToast}>
+            {errorMessage}
           </div>
         )}
       </div>
diff --git a/src/admin/pages/site/toolbar/PublishButton.tsx b/src/admin/pages/site/toolbar/PublishButton.tsx
@@ -44,7 +44,7 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
   const hasUnsavedChanges = useEditorStore((s) => s.hasUnsavedChanges)
   const { runStepUp } = useStepUp()
   const [state, setState] = useState<PublishState>('idle')
-  const [message, setMessage] = useState<string | null>(null)
+  const [errorMessage, setErrorMessage] = useState<string | null>(null)
   const [isSaving, setIsSaving] = useState(false)
   const [scheduleDialogOpen, setScheduleDialogOpen] = useState(false)
   const statusTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null)
@@ -67,7 +67,7 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
         if (cancelled) return
         if (status.draftMatchesPublished) {
           setState('published')
-          setMessage(null)
+          setErrorMessage(null)
         }
       } catch (err) {
         console.warn('[toolbar] Failed to load publish status:', err)
@@ -84,7 +84,7 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
     statusTimerRef.current = null
     const resetTimer = setTimeout(() => {
       setState('idle')
-      setMessage(null)
+      setErrorMessage(null)
     }, 0)
     return () => clearTimeout(resetTimer)
   }, [hasUnsavedChanges, state])
@@ -93,15 +93,7 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
     if (statusTimerRef.current) clearTimeout(statusTimerRef.current)
     statusTimerRef.current = setTimeout(() => {
       setState('idle')
-      setMessage(null)
-      statusTimerRef.current = null
-    }, 5000)
-  }
-
-  const clearMessageLater = () => {
-    if (statusTimerRef.current) clearTimeout(statusTimerRef.current)
-    statusTimerRef.current = setTimeout(() => {
-      setMessage(null)
+      setErrorMessage(null)
       statusTimerRef.current = null
     }, 5000)
   }
@@ -115,7 +107,7 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
     }
 
     setState('publishing')
-    setMessage(null)
+    setErrorMessage(null)
 
     try {
       await onSave?.()
@@ -125,25 +117,19 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
       // blast-radius site action (one click replaces every public page),
       // which is why the server gates it behind a fresh step-up window
       // in addition to the `pages.publish` capability check.
-      const result = await runStepUp(() => publishCmsDraft())
+      await runStepUp(() => publishCmsDraft())
       setState('published')
-      setMessage(
-        result.publishedPages === 1
-          ? '1 page published'
-          : `${result.publishedPages} pages published`,
-      )
-      clearMessageLater()
     } catch (err) {
       if (err instanceof Error && err.message === StepUpCancelledMessage) {
         // User dismissed the step-up dialog — return the button to its
         // resting state without surfacing an error message; this is the
         // same UX every other step-up-gated action uses.
         setState('idle')
-        setMessage(null)
+        setErrorMessage(null)
         return
       }
       setState('error')
-      setMessage(getErrorMessage(err, 'Unknown publish error'))
+      setErrorMessage(getErrorMessage(err, 'Unknown publish error'))
       resetErrorLater()
     }
   }
@@ -236,10 +222,7 @@ export function PublishButton({ enabled = true, onSave, saveStatus }: PublishBut
         publishIcon={PublishIcon}
         onPublish={handlePublish}
         menuItems={menuItems}
-        toast={message ? {
-          tone: state === 'error' ? 'alert' : 'status',
-          message,
-        } : null}
+        errorMessage={errorMessage}
       />
       {activePage && (
         <SchedulePublishDialog
diff --git a/src/admin/pages/site/toolbar/Toolbar.module.css b/src/admin/pages/site/toolbar/Toolbar.module.css
@@ -272,11 +272,6 @@
     box-shadow: 0 4px 12px var(--scrim-40);
 }
 
-.publishToastStatus {
-    border-color: color-mix(in srgb, var(--success) 35%, transparent);
-    color: var(--success);
-}
-
 @media (max-width: 760px) {
     .header {
         height: 68px;
