London | 26-SDC-July | Raihan Sharif | Sprint 2 | rebloom by RaihanSharif · Pull Request #321 · CodeYourFuture/Module-Legacy-Code

RaihanSharif · 2026-10-22T12:59:36Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1171

Changelist

Blooms have a rebloom button, and rebloom count.

Users can "rebloom" a bloom they haven't already rebloomed.

On reblooming:

the rebloom gets added to the user's timeline, and their profile timeline.
reblooms by followed users also gets added to the home timeline.
reblooms done by currently logged in user are green.
reblooms by other users are in purple.
all reblooms are non-rebloomable. You must go to the original to rebloom.

Fetches blooms on navigation to a page, as stale cache was an issue.

initial implementation of how reblooms will be recorded. A rebloom refers to a bloom, and rebloomer. Get rebloom count by number of rows for a given bloom id in reblooms table.

By combining the blooms and reblooms, the home_timeline, other_profile endpoints don't have to change much.

The before clause now uses WHERE because it's filtering the combined blooms/reblooms. Use correct placeholder for username

add a helper function to get reblooms by a user from a given list of blooms.

…ly logged in user

Previously going to profile would keep stale bloom data, and only purging the localStorage would fix it.

iscmiguelsamaniego

Solid, modular Rebloom feature! Just clean up the duplicate returns in Python, wrap your rebloom button states in try...finally, add .catch() error handling to routing fetches, and round out your .gitignore with Python/Node exclusions.

iscmiguelsamaniego · 2026-10-28T02:21:25Z

Great progress on the reblooms implementation! Here are two quick questions to help refine the code:

Duplicate returns: In functions like home_timeline, user_blooms, and hashtag, did you notice consecutive return statements? How might that affect whether _mark_rebloomed_by_me gets executed?

Query performance: By using subqueries to count reblooms for every row in the main queries, how do you think the database performance will scale as the dataset grows?

On the first question, I'm not quite sure what you're hinting at. Looking at those three functions again, it doesn't look like there's are consecutive return statements.

iscmiguelsamaniego · 2026-10-28T02:23:12Z

Great, Here are a couple of quick questions to help refine it:

Unreachable Code: In functions like home_timeline, user_blooms, and hashtag, did you notice that the second return statement is placed right after the first one? How might that affect whether _mark_rebloomed_by_me is ever executed?

Variable Definitions: In self_profile(), are profile_user and profile_username defined before they are used in followers and blooms.get_blooms_for_user()?

iscmiguelsamaniego · 2026-10-28T02:24:31Z

Great routing setup! Notice the data type used for the port parameter in app.run()—might an integer be preferred there? Also, are all the imported view functions (like self_profile and register) accounted for in your URL rules?

iscmiguelsamaniego · 2026-10-28T02:25:25Z

Clean schema design with proper constraints and well-chosen indexes! How do you envision reblooms_bloom_id_idx and reblooms_user_ts_idx supporting your queries for timelines and rebloom counts?

iscmiguelsamaniego · 2026-10-28T02:26:07Z

Clean component logic for rendering reblooms!

Notice how bloomFrag is queried right at the start before it's defined or cloned from the template—how might we ensure the template is properly cloned into bloomFrag before accessing its elements?

iscmiguelsamaniego · 2026-10-28T02:27:21Z

Great job structuring the routing logic to cleanly distinguish between real navigation and state re-renders!

Notice how apiService.getBloom includes a .catch() for error handling—might the other profile and hashtag fetch calls also benefit from error handling to prevent unhandled rejections if a network request fails?

iscmiguelsamaniego · 2026-10-28T02:28:17Z

Clean styling! Just consider using a CSS variable for the green border and ensure display: flex is set on the footer.

iscmiguelsamaniego · 2026-10-28T02:28:52Z

Clean and well-structured HTML template! Just remove the duplicate comments and ensure you use cloneNode(true) when instantiating it.

iscmiguelsamaniego · 2026-10-28T02:29:34Z

Great event delegation! Just make sure to pass event into your state-change listener, wrap the rebloom action in a try...finally to reset the button state on error, and remove the redundant refreshRouteData() call on load.

iscmiguelsamaniego · 2026-10-28T02:30:08Z

Good start! Have you considered adding ignores for your Python (venv, __pycache__, .env) and Node (node_modules, dist) environments?

…leErrorDialog functino

…om endpoints

RaihanSharif added 28 commits October 14, 2026 13:00

add .vscode to gitignore

d67f9bc

Add rebloom table to schema

1dcb7f4

initial implementation of how reblooms will be recorded. A rebloom refers to a bloom, and rebloomer. Get rebloom count by number of rows for a given bloom id in reblooms table.

Updat Bloom dataclass to include rebloom data

3c5672b

function to add rebloom to db

1055838

Get blooms and reblooms of a given user.

4c66d37

By combining the blooms and reblooms, the home_timeline, other_profile endpoints don't have to change much.

update sorting to sort first by rebloom timestamp, then bloom timestamp

c26ab69

No need to reverse, already sorted by timestamp in the db query.

3a2b2af

use CURRENT_TIMESTAMP instead of now()

744fb49

add an endpoint for sending rebloom

89198e5

fix: fix get_blooms_for_user

5a78606

The before clause now uses WHERE because it's filtering the combined blooms/reblooms. Use correct placeholder for username

add request method to rebloom url_rule

e3b147e

update bloom template to show rebloom info

44b0000

Make send_rebloom response consistent with other endpoint functions

56ed6c4

update bloom template to include a label for the rebloom button

ee58b96

tracking logged in user reblooming.

2f3549b

add a helper function to get reblooms by a user from a given list of blooms.

update endpoints to indicate if a bloom has been rebloomed by current…

dae3187

…ly logged in user

hashtag page indicates user rebloomed blooms

5efd8a3

api function to send rebloom

d7a3d16

add event listener for rebloom button

e9c6d91

bloom component includes rebloom data

bbc3f45

fix import

95b4611

bloom component with rebloom, initial version

53538a8

fix inconsistent rebloom count

7494f51

show rebloom count on all pages

877b7ed

fix bloomcount bug

9b44eef

make self-rebloom more visually distinct from others' rebloom

e25645a

fix: update stale state when page refresh.

11dfa5c

use UTC timezone in rebloom

ef41fa6

github-project-automation Bot added this to Purple Forest Kanban Oct 22, 2026

github-project-automation Bot moved this to Backlog in Purple Forest Kanban Oct 22, 2026

refretch data on changing views.

2f5b39a

Previously going to profile would keep stale bloom data, and only purging the localStorage would fix it.

RaihanSharif force-pushed the feature/rebloom branch from 7e599de to 2f5b39a Compare October 22, 2026 13:02

RaihanSharif added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 22, 2026

iscmiguelsamaniego approved these changes Oct 28, 2026

View reviewed changes

RaihanSharif added 3 commits October 28, 2026 20:13

Add try/catch block around rebloom request and handle error with hand…

c5d9d91

…leErrorDialog functino

use the same "bloom not found" message and return format as other blo…

32c1bea

…om endpoints

Don't need f strings

a12bc78

Navigation Menu

Repository navigation

London | 26-SDC-July | Raihan Sharif | Sprint 2 | rebloom - #321

London | 26-SDC-July | Raihan Sharif | Sprint 2 | rebloom#321
RaihanSharif wants to merge 32 commits into
CodeYourFuture:mainfrom
RaihanSharif:feature/rebloom

RaihanSharif commented Oct 22, 2026

Uh oh!

iscmiguelsamaniego left a comment

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

RaihanSharif Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

iscmiguelsamaniego Oct 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

RaihanSharif commented Oct 22, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

iscmiguelsamaniego left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants