Added "last" and a reversed ?playlistPosition in playlist URL#3974
Merged
Chocobozzz merged 6 commits intoApr 26, 2021
Merged
Conversation
Chocobozzz
requested changes
Apr 21, 2021
|
|
||
| updatePlaylistIndex (position: number) { | ||
| if (this.playlistElements.length === 0 || !position) return | ||
| if (position < 0) position = (this.playlistPagination.totalItems + 1) + position // Handle the "reverse" index |
Owner
There was a problem hiding this comment.
I don't think you need to calculate the position here since you already built it in the video watch component
Contributor
Author
There was a problem hiding this comment.
Actually, the position is not properly calculated in the video watch component, because this.playlist is undefined at that time. In the commit I just pushed, I got rid of it. In the video watch component, this.playlistPosition can be negative, while updatePlaylistIndex() does the job of translating the actually negative position into an index it can use.
Owner
|
Thanks @Poslovitch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented the
?playlistPosition=lastalongside a "new" feature: the ability to provide a negative playlistPosition, which acts like a "reversed" array index.?playlistPosition=-1selects the first video from the bottom of the playlist,?playlistPosition=-2the second, etc.This was done as to avoid modifying the prototype of the
updatePlaylistIndex (position: number)method.Related issues
Resolves #3897.
Has this been tested?
?playlistPosition=lastworks.?playlistPosition=-1,?playlistPosition=-3, etc. works.?playlistPosition=1,?playlistPosition=3, etc. works.?playlistPosition=-100is defaulted to 1.?playlistPosition=saladedefruitis defaulted to 1.