Skip to content

Add fcbk open-graph and twitter-card metas for accounts, video-channels, playlists urls#2996

Merged
Chocobozzz merged 6 commits into
Chocobozzz:developfrom
kimsible:feat/share-account-and-channel
Jul 31, 2020
Merged

Add fcbk open-graph and twitter-card metas for accounts, video-channels, playlists urls#2996
Chocobozzz merged 6 commits into
Chocobozzz:developfrom
kimsible:feat/share-account-and-channel

Conversation

@kimsible

@kimsible kimsible commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Fixes: #2989

Tests :

$ npm run build:server
$ NODE_ENV=test npm start

# Playlist 
$ curl http://localhost:9000/videos/watch/playlist/:uuid

# Account
$ curl http://localhost:9000/accounts/:username

# Channel
$ curl http://localhost:9000/video-channels/:name

og-fcbk-playlist
og-fcbk-channel
og-fcbk-account

@kimsible kimsible force-pushed the feat/share-account-and-channel branch from c4dea59 to 9a6e49d Compare July 23, 2020 12:47
Chocobozzz
Chocobozzz reviewed Jul 23, 2020
View reviewed changes

@Chocobozzz Chocobozzz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for accounts, channels and playlists meta tags? https://github.com/Chocobozzz/PeerTube/blob/develop/server/tests/client.ts

Maybe you could also refactor addAccountOrChannelOpenGraphAndMetaTags, addVideoPlaylistOpenGraphAndMetaTags and addVideoOpenGraphAndOEmbedTags methods that share some code

@kimsible kimsible force-pushed the feat/share-account-and-channel branch from 9cfca56 to ae174d8 Compare July 26, 2020 21:41
@Chocobozzz

Chocobozzz commented Jul 27, 2020

Copy link
Copy Markdown
Owner

Please fix lint tests and https://travis-ci.com/github/Chocobozzz/PeerTube/jobs/365185689 test

@kimsible

kimsible commented Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

Please fix lint tests and https://travis-ci.com/github/Chocobozzz/PeerTube/jobs/365185689 test

I'll try but the tests still not work in local, maybe I should open an issue, it's a serious problem for contributions...

@Chocobozzz

Chocobozzz commented Jul 28, 2020

Copy link
Copy Markdown
Owner

I'll try but the tests still not work in local, maybe I should open an issue, it's a serious problem for contributions...

Yes please

@kimsible

kimsible commented Jul 29, 2020

Copy link
Copy Markdown
Contributor Author

Could you add tests for accounts, channels and playlists meta tags? https://github.com/Chocobozzz/PeerTube/blob/develop/server/tests/client.

I"ve added some tests, but I still have this problem with local tests #3022

Maybe you could also refactor addAccountOrChannelOpenGraphAndMetaTags, addVideoPlaylistOpenGraphAndMetaTags and addVideoOpenGraphAndOEmbedTags methods that share some code

I've refactored all these methods.

@Chocobozzz

Chocobozzz commented Jul 31, 2020

Copy link
Copy Markdown
Owner

Thanks

@Chocobozzz Chocobozzz merged commit 8d987ec into Chocobozzz:develop Jul 31, 2020
@Chocobozzz Chocobozzz mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chocobozzz Chocobozzz Chocobozzz left review comments

Assignees

No one assigned

Labels

Status: Waiting for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Meta image and description sharing account or channel url

2 participants

@kimsible @Chocobozzz