Refactored#3
Open
SamarthJ-24 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have chosen your project for refactoring because I have to perform the following task to complete my university assignment. I request you to accept my pull request which will help me to gain points in my assignment. I have made following changes, you can accept as many commit as you want.
Thank you.
Refactoring
src->ru.arhiser
Commented the programs 1. Package Iterator -> MainFieldEnum.java, 2. Package sort -> comparator -> Main.java because the programs were using the library ru.arhiser.object and this was not present in the package ru.arhiser.
Therefore, because of these packages the project was unable to compile.
Rename Method/Variable:
Variable= Package- bitops, Line of Code: 47
Method= Package- huffman, Line of Code: 65
Extract Method: Package- bitops, Line of Code: 46
Move Method: Package- huffman, Before Line of Code: 65, After refactoring line of code: 99
Method moved to class CodeTreeNode because this method uses more method of CodeTreeNode than calling its own methods.
Extract Class: Package- huffman_adapt.digital, Class- CoderTestApp
Pull Up Method: Package- fract_noise, Class- FractalNoise.java, Noise.java