Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5873.
An invalid
assistant_output_coloris reset toNoneby color validation. Both assistant reply renderers then pass it to Rich Markdown, which raisesAttributeErrorbefore the model's edits can be applied. Use Rich's default"none"style for disabled colors in the streaming and regular renderers, while preserving configured valid colors.Validation:
None, empty, and valid colors in both renderers. The original implementation fails four subtests; all eight pass with the fix.tests/basic/test_io.pyandtests/basic/test_coder.py: 66 passed and 37 subtests passed. The existingtest_color_initializationfails in this non-interactive Windows environment because PromptSession requires a Windows console; the same test also fails on the unchanged base checkout.Coder.runscenarios use LiteLLM mock responses with streaming enabled/disabled and invalid/disabled/valid colors. Every scenario renders the reply and applies its edit to a real local file.