Make OSS licenses plugin safe to any application order#321
Merged
Conversation
davidmotson
previously approved these changes
Aug 9, 2025
Delete the entire directory instead of individual files. This is in prepration to moving LicensesTask to a single output directory to make it compatible with the new AGP variants API.
This is in preparation to use the new AGP variants API to register resource creation.
The old API is getting removed with AGP 9.0.0. This bumps the minimum required version of AGP to 8.2 and moves to the new variants API.
Prior to this change there was an implicit order of application of plugins with com.android.application having to be applied before com.google.android.gms.oss-licenses-plugin. This change makes licenses plugin apply all of the logic despite the order of application.
VinayGuthal
approved these changes
Aug 14, 2025
AsiaTopindy
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change there was an implicit order of application of
plugins with com.android.application having to be applied before
com.google.android.gms.oss-licenses-plugin. This change makes licenses
plugin apply all of the logic despite the order of application.