deps: Use `nu-ansi-term` to replace unmaintained `ansi_term` by poliorcetics · Pull Request #2287 · tokio-rs/tracing

poliorcetics · 2022-08-24T08:06:31Z

This increases the MSRV of tracing-subscriber to 1.50+.

Motivation

ansi_term last time update is over 2 years ago, use
nushell team forked nu-ansi-term instead

Solution

Use nu-ansi-term

poliorcetics · 2022-08-24T08:07:50Z

I updated the MSRV only for tracing-subscriber, is that correct ?

I also used a more recent version of nu-ansi-term than the seemingly abandoned PR at #2040

hawkw

this looks fine to me, and I'm okay with making the MSRV bump to 1.50.0. honestly, it would probably be fine to just do a global bump to 1.50.0, but we should consider that separately.

however, in addition to bumping the MSRV that's tested on CI, we'll also need to do a few other things to bump MSRV for tracing-subscriber:

update the version mentioned in the README here:

tracing/tracing-subscriber/README.md

Line 35 in 41337ba

*Compiler support: [requires `rustc` 1.49+][msrv]*

and here:

tracing/tracing-subscriber/README.md

Lines 41 to 42 in 41337ba

    
           Tracing is built against the latest stable release. The minimum supported 
        
           version is 1.49. The current Tracing version is not guaranteed to build on Rust

update the version mentioned in the lib.rs docs here:

tracing/tracing-subscriber/src/lib.rs

Line 13 in 41337ba

//! *Compiler support: [requires `rustc` 1.49+][msrv]*

and here:

tracing/tracing-subscriber/src/lib.rs

Lines 108 to 109 in 41337ba

    
           //! Tracing is built against the latest stable release. The minimum supported 
        
           //! version is 1.49. The current Tracing version is not guaranteed to build on

update the rust-version key in Cargo.toml here:

tracing/tracing-subscriber/Cargo.toml

Line 23 in 41337ba

rust-version = "1.49.0"

once those are taken care of, I'll be happy to merge this!

poliorcetics · 2022-08-25T12:32:37Z

I think you didn't have some changes I made ? I had some of the MSRV changes already done, but I missed those in the lib.rs and Cargo.toml

hawkw · 2022-08-25T17:10:16Z

Thanks, it looks like all the docs have been updated. This looks good to me, except that we should probably be keeping tracing-subscriber in the build matrix's subcrate list, as I discussed here: #2287 (comment).

Once that's addressed, I'll be happy to merge this! :)

This increases the MSRV of `tracing-subscriber` to 1.50+.

…table

hawkw

looks good to me, thank you!

matschaffer · 2022-08-31T01:36:41Z

Looks like this fixes #2282 - mentioning it for easier discovery from the "RUSTSEC" titled issue.

davidbarsky · 2022-09-08T17:34:30Z

Note to self: to backport this, I need to backport #1069 as well. Eliza tells me that at the time she couldn't decide whether that was a breaking change or not, but has since decided that it's not since that formatter is human, not machine-readable.

hawkw · 2022-09-08T18:27:06Z

@davidbarsky it should be possible to modify the code a bit so that the change to the Compact formatter isn't necessary to backport this?

davidbarsky · 2022-09-08T19:55:50Z

it should, but i'd also like to backport this, but i'll do it in a follow up PR.

fixes #143 remove ansi terminal colors temporarily until `tracing-subscriber` backports `nu-ansi-style` refs: tokio-rs/tracing#2287

This increases the MSRV of `tracing-subscriber` to 1.50+. ## Motivation [ansi_term] last time update is over 2 years ago, use nushell team forked [nu-ansi-term] instead ## Solution Use [nu-ansi-term]. Closes #2040 [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term

@cgbur

# 0.3.16 (October 6, 2022) This release of `tracing-subscriber` fixes a regression introduced in [v0.3.15][subscriber-0.3.15] where `Option::None`'s `Layer` implementation would set the max level hint to `OFF`. In addition, it adds several new APIs, including the `Filter::event_enabled` method for filtering events based on fields values, and the ability to log internal errors that occur when writing a log line. This release also replaces the dependency on the unmaintained [`ansi-term`] crate with the [`nu-ansi-term`] crate, resolving an *informational* security advisory ([RUSTSEC-2021-0139] for [`ansi-term`]'s maintainance status. This increases the minimum supported Rust version (MSRV) to Rust 1.50+, although the crate should still compile for the previous MSRV of Rust 1.49+ when the `ansi` feature is not enabled. ### Fixed - **layer**: `Option::None`'s `Layer` impl always setting the `max_level_hint` to `LevelFilter::OFF` (#2321) - Compilation with `-Z minimal versions` (#2246) - **env-filter**: Clarify that disabled level warnings are emitted by `tracing-subscriber` (#2285) ### Added - **fmt**: Log internal errors to `stderr` if writing a log line fails (#2102) - **fmt**: `FmtLayer::log_internal_errors` and `FmtSubscriber::log_internal_errors` methods for configuring whether internal writer errors are printed to `stderr` (#2102) - **fmt**: `#[must_use]` attributes on builders to warn if a `Subscriber` is configured but not set as the default subscriber (#2239) - **filter**: `Filter::event_enabled` method for filtering an event based on its fields (#2245, #2251) - **filter**: `Targets::default_level` accessor (#2242) ### Changed - **ansi**: Replaced dependency on unmaintained `ansi-term` crate with `nu-ansi-term` ((#2287, fixes informational advisory [RUSTSEC-2021-0139]) - `tracing-core`: updated to [0.1.30][core-0.1.30] - Minimum Supported Rust Version (MSRV) increased to Rust 1.50+ (when the `ansi`) feature flag is enabled (#2287) ### Documented - **fmt**: Correct inaccuracies in `fmt::init` documentation (#2224) - **filter**: Fix incorrect doc link in `filter::Not` combinator (#2249) Thanks to new contributors @cgbur, @DesmondWillowbrook, @RalfJung, and @poliorcetics, as well as returning contributors @CAD97, @connec, @jswrenn, @guswynn, and @bryangarza, for contributing to this release! [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term [RUSTSEC-2021-0139]: https://rustsec.org/advisories/RUSTSEC-2021-0139.html [core-0.1.30]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.30 [subscriber-0.3.15]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.15

This increases the MSRV of `tracing-subscriber` to 1.50+. ## Motivation [ansi_term] last time update is over 2 years ago, use nushell team forked [nu-ansi-term] instead ## Solution Use [nu-ansi-term]. Closes #2040 [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term

@cgbur

# 0.3.16 (October 6, 2022) This release of `tracing-subscriber` fixes a regression introduced in [v0.3.15][subscriber-0.3.15] where `Option::None`'s `Layer` implementation would set the max level hint to `OFF`. In addition, it adds several new APIs, including the `Filter::event_enabled` method for filtering events based on fields values, and the ability to log internal errors that occur when writing a log line. This release also replaces the dependency on the unmaintained [`ansi-term`] crate with the [`nu-ansi-term`] crate, resolving an *informational* security advisory ([RUSTSEC-2021-0139] for [`ansi-term`]'s maintainance status. This increases the minimum supported Rust version (MSRV) to Rust 1.50+, although the crate should still compile for the previous MSRV of Rust 1.49+ when the `ansi` feature is not enabled. ### Fixed - **layer**: `Option::None`'s `Layer` impl always setting the `max_level_hint` to `LevelFilter::OFF` (#2321) - Compilation with `-Z minimal versions` (#2246) - **env-filter**: Clarify that disabled level warnings are emitted by `tracing-subscriber` (#2285) ### Added - **fmt**: Log internal errors to `stderr` if writing a log line fails (#2102) - **fmt**: `FmtLayer::log_internal_errors` and `FmtSubscriber::log_internal_errors` methods for configuring whether internal writer errors are printed to `stderr` (#2102) - **fmt**: `#[must_use]` attributes on builders to warn if a `Subscriber` is configured but not set as the default subscriber (#2239) - **filter**: `Filter::event_enabled` method for filtering an event based on its fields (#2245, #2251) - **filter**: `Targets::default_level` accessor (#2242) ### Changed - **ansi**: Replaced dependency on unmaintained `ansi-term` crate with `nu-ansi-term` ((#2287, fixes informational advisory [RUSTSEC-2021-0139]) - `tracing-core`: updated to [0.1.30][core-0.1.30] - Minimum Supported Rust Version (MSRV) increased to Rust 1.50+ (when the `ansi`) feature flag is enabled (#2287) ### Documented - **fmt**: Correct inaccuracies in `fmt::init` documentation (#2224) - **filter**: Fix incorrect doc link in `filter::Not` combinator (#2249) Thanks to new contributors @cgbur, @DesmondWillowbrook, @RalfJung, and @poliorcetics, as well as returning contributors @CAD97, @connec, @jswrenn, @guswynn, and @bryangarza, for contributing to this release! [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term [RUSTSEC-2021-0139]: https://rustsec.org/advisories/RUSTSEC-2021-0139.html [core-0.1.30]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.30 [subscriber-0.3.15]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.15

@cgbur

# 0.3.16 (October 6, 2022) This release of `tracing-subscriber` fixes a regression introduced in [v0.3.15][subscriber-0.3.15] where `Option::None`'s `Layer` implementation would set the max level hint to `OFF`. In addition, it adds several new APIs, including the `Filter::event_enabled` method for filtering events based on fields values, and the ability to log internal errors that occur when writing a log line. This release also replaces the dependency on the unmaintained [`ansi-term`] crate with the [`nu-ansi-term`] crate, resolving an *informational* security advisory ([RUSTSEC-2021-0139] for [`ansi-term`]'s maintainance status. This increases the minimum supported Rust version (MSRV) to Rust 1.50+, although the crate should still compile for the previous MSRV of Rust 1.49+ when the `ansi` feature is not enabled. ### Fixed - **layer**: `Option::None`'s `Layer` impl always setting the `max_level_hint` to `LevelFilter::OFF` (#2321) - Compilation with `-Z minimal versions` (#2246) - **env-filter**: Clarify that disabled level warnings are emitted by `tracing-subscriber` (#2285) ### Added - **fmt**: Log internal errors to `stderr` if writing a log line fails (#2102) - **fmt**: `FmtLayer::log_internal_errors` and `FmtSubscriber::log_internal_errors` methods for configuring whether internal writer errors are printed to `stderr` (#2102) - **fmt**: `#[must_use]` attributes on builders to warn if a `Subscriber` is configured but not set as the default subscriber (#2239) - **filter**: `Filter::event_enabled` method for filtering an event based on its fields (#2245, #2251) - **filter**: `Targets::default_level` accessor (#2242) ### Changed - **ansi**: Replaced dependency on unmaintained `ansi-term` crate with `nu-ansi-term` ((#2287, fixes informational advisory [RUSTSEC-2021-0139]) - `tracing-core`: updated to [0.1.30][core-0.1.30] - Minimum Supported Rust Version (MSRV) increased to Rust 1.50+ (when the `ansi`) feature flag is enabled (#2287) ### Documented - **fmt**: Correct inaccuracies in `fmt::init` documentation (#2224) - **filter**: Fix incorrect doc link in `filter::Not` combinator (#2249) Thanks to new contributors @cgbur, @DesmondWillowbrook, @RalfJung, and @poliorcetics, as well as returning contributors @CAD97, @connec, @jswrenn, @guswynn, and @bryangarza, for contributing to this release! [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term [RUSTSEC-2021-0139]: https://rustsec.org/advisories/RUSTSEC-2021-0139.html [core-0.1.30]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.30 [subscriber-0.3.15]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.15

…io-rs#2287) This increases the MSRV of `tracing-subscriber` to 1.50+. ## Motivation [ansi_term] last time update is over 2 years ago, use nushell team forked [nu-ansi-term] instead ## Solution Use [nu-ansi-term]. Closes tokio-rs#2040 [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term

@cgbur

# 0.3.16 (October 6, 2022) This release of `tracing-subscriber` fixes a regression introduced in [v0.3.15][subscriber-0.3.15] where `Option::None`'s `Layer` implementation would set the max level hint to `OFF`. In addition, it adds several new APIs, including the `Filter::event_enabled` method for filtering events based on fields values, and the ability to log internal errors that occur when writing a log line. This release also replaces the dependency on the unmaintained [`ansi-term`] crate with the [`nu-ansi-term`] crate, resolving an *informational* security advisory ([RUSTSEC-2021-0139] for [`ansi-term`]'s maintainance status. This increases the minimum supported Rust version (MSRV) to Rust 1.50+, although the crate should still compile for the previous MSRV of Rust 1.49+ when the `ansi` feature is not enabled. ### Fixed - **layer**: `Option::None`'s `Layer` impl always setting the `max_level_hint` to `LevelFilter::OFF` (tokio-rs#2321) - Compilation with `-Z minimal versions` (tokio-rs#2246) - **env-filter**: Clarify that disabled level warnings are emitted by `tracing-subscriber` (tokio-rs#2285) ### Added - **fmt**: Log internal errors to `stderr` if writing a log line fails (tokio-rs#2102) - **fmt**: `FmtLayer::log_internal_errors` and `FmtSubscriber::log_internal_errors` methods for configuring whether internal writer errors are printed to `stderr` (tokio-rs#2102) - **fmt**: `#[must_use]` attributes on builders to warn if a `Subscriber` is configured but not set as the default subscriber (tokio-rs#2239) - **filter**: `Filter::event_enabled` method for filtering an event based on its fields (tokio-rs#2245, tokio-rs#2251) - **filter**: `Targets::default_level` accessor (tokio-rs#2242) ### Changed - **ansi**: Replaced dependency on unmaintained `ansi-term` crate with `nu-ansi-term` ((tokio-rs#2287, fixes informational advisory [RUSTSEC-2021-0139]) - `tracing-core`: updated to [0.1.30][core-0.1.30] - Minimum Supported Rust Version (MSRV) increased to Rust 1.50+ (when the `ansi`) feature flag is enabled (tokio-rs#2287) ### Documented - **fmt**: Correct inaccuracies in `fmt::init` documentation (tokio-rs#2224) - **filter**: Fix incorrect doc link in `filter::Not` combinator (tokio-rs#2249) Thanks to new contributors @cgbur, @DesmondWillowbrook, @RalfJung, and @poliorcetics, as well as returning contributors @CAD97, @connec, @jswrenn, @guswynn, and @bryangarza, for contributing to this release! [nu-ansi-term]: https://github.com/nushell/nu-ansi-term [ansi_term]: https://github.com/ogham/rust-ansi-term [RUSTSEC-2021-0139]: https://rustsec.org/advisories/RUSTSEC-2021-0139.html [core-0.1.30]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.30 [subscriber-0.3.15]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.15

poliorcetics requested review from a team, davidbarsky and hawkw as code owners August 24, 2022 08:06

hawkw requested changes Aug 24, 2022

View reviewed changes

Comment thread .github/workflows/CI.yml Resolved

poliorcetics added 2 commits August 29, 2022 12:31

deps: Use nu-ansi-term to replace unmaintained ansi_term

a018ede

This increases the MSRV of `tracing-subscriber` to 1.50+.

fix: add tracing-{appender,subscriber} to minimal version checks on s…

2c85c79

…table

hawkw approved these changes Aug 29, 2022

View reviewed changes

hawkw enabled auto-merge (squash) August 29, 2022 21:01

hawkw merged commit f09bc43 into tokio-rs:master Aug 29, 2022

poliorcetics deleted the nu-ansi-term branch August 30, 2022 09:20

matschaffer mentioned this pull request Aug 31, 2022

ansi_term dependency is unmaintained in tracing-subscriber crate #2281

Closed

MTRNord mentioned this pull request Sep 2, 2022

RUSTSEC-2021-0139: ansi_term is Unmaintained erooster-mail/erooster#34

Closed

bluejekyll mentioned this pull request Sep 3, 2022

ansi_term is unsupported hickory-dns/hickory-dns#1767

Closed

davidbarsky added the needs-backport label Sep 8, 2022

kemingy mentioned this pull request Sep 18, 2022

security: RUSTSEC-2021-0139 mosecorg/mosec#218

Closed

TennyZhuang mentioned this pull request Sep 19, 2022

security: RUSTSEC-2021-0139 risingwavelabs/risingwave#5421

Closed

siketyan mentioned this pull request Oct 6, 2022

RUSTSEC-2021-0139: ansi_term is Unmaintained #2282

Closed

hawkw mentioned this pull request Oct 6, 2022

subscriber: prepare to release v0.3.16 #2342

Merged

davidbarsky mentioned this pull request Sep 26, 2023

chore: backport roughly a year's worth of changes #2728

Merged

bzm3r mentioned this pull request Oct 13, 2023

tracing-subscriber should not use nu-ansi-term and prefer another crate like owo_colors or colored #2759

Open

Navigation Menu

Repository navigation

deps: Use `nu-ansi-term` to replace unmaintained `ansi_term` - #2287

deps: Use `nu-ansi-term` to replace unmaintained `ansi_term`#2287
hawkw merged 2 commits into
tokio-rs:masterfrom
poliorcetics:nu-ansi-term

poliorcetics commented Aug 24, 2022

Uh oh!

poliorcetics commented Aug 24, 2022

Uh oh!

hawkw left a comment

Uh oh!

Uh oh!

poliorcetics commented Aug 25, 2022

Uh oh!

hawkw commented Aug 25, 2022

Uh oh!

hawkw left a comment

Uh oh!

matschaffer commented Aug 31, 2022

Uh oh!

davidbarsky commented Sep 8, 2022

Uh oh!

hawkw commented Sep 8, 2022

Uh oh!

davidbarsky commented Sep 8, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	Tracing is built against the latest stable release. The minimum supported
	version is 1.49. The current Tracing version is not guaranteed to build on Rust

	//! Tracing is built against the latest stable release. The minimum supported
	//! version is 1.49. The current Tracing version is not guaranteed to build on

Conversation

poliorcetics commented Aug 24, 2022

Motivation

Solution

Uh oh!

poliorcetics commented Aug 24, 2022

Uh oh!

hawkw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

poliorcetics commented Aug 25, 2022

Uh oh!

hawkw commented Aug 25, 2022

Uh oh!

hawkw left a comment

Choose a reason for hiding this comment

Uh oh!

matschaffer commented Aug 31, 2022

Uh oh!

davidbarsky commented Sep 8, 2022

Uh oh!

hawkw commented Sep 8, 2022

Uh oh!

davidbarsky commented Sep 8, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants