20260610-ssl_api_ext-revert-ret-cascades#10654
Open
douzzer wants to merge 3 commits into
Open
Conversation
…turns that were refactored away in 359e688, fixing null pointer deref regression in wolfSSL_UseALPN() (possibly others too).
…erver}_method*() to induce compile-time failures for TLS/SSL usage in NO_TLS configurations.
…sl_pk.c: add missing gates on !NO_TLS.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10654
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
Author
|
retest this please |
dgarske
approved these changes
Jun 10, 2026
dgarske
left a comment
Member
There was a problem hiding this comment.
Allowing this revert even though I am not a fan, but it does de-risk so close to the release.
Contributor
Author
|
Linking related PR #10569 The defect detected by clang UB sanitizer: |
Contributor
Author
|
Don't merge -- pending followup/replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit in this PR just reverts semantically unchanged functions refactored by 359e688, reverting them to their exact pre-refactor form as of the prior commit, 4f09916. Several whitespace changes in these functions are also reverted. All substantive changes in 359e688 are carried forward.
--
src/ssl_api_ext.candsrc/ssl_api_pk.c: restore earlyBAD_FUNC_ARGreturns that were refactored away in 359e688, fixing null pointer deref regression inwolfSSL_UseALPN()(possibly others too).wolfssl/ssl.h: add !NO_TLSgate around prototypes forwolf*_{client,server}_method*()to induce compile-time failures for TLS/SSL usage inNO_TLSconfigurations.tests/api/test_ssl_cert.c,tests/api/test_ssl_ext.c,tests/api/test_ssl_pk.c: add missing gates on !NO_TLS.--
fixes failures on
all-no-tls,lms-xmss-wolfssl-all-clang-sanitizer,sanitizer-clang-all-noasm, andsanitizer-clang-all-intelasm.--
tested with