fix extension length underflow in sniffer hello parsers#10643
Open
netliomax25-code wants to merge 1 commit into
Open
fix extension length underflow in sniffer hello parsers#10643netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lentaken from the 2-byte extensions length, but the per-extension guard only checksextLen > *sslBytes(bytes left in the capture), not the remaininglen.extLenabove the remaininglenbut still under*sslBytespasses that guard, solen -= extLen + EXT_TYPE_SZ + LENGTH_SZwraps and the loop keeps reading extension headers past the end of the frame.extLenagainst the remaininglenat both sites so the subtraction cannot underflow.Validated against an ASAN build of the loop: a ServerHello declaring an extensions length of 4 in a frame with 6 captured bytes and one extension of extLen 2 reads 2 bytes past the buffer before the change, and returns an input error cleanly after it.