Skip to content

Enable windup's tests on Windows and MacOS#1671

Open
mrizzi wants to merge 13 commits into
windup:masterfrom
mrizzi:run-multi-os-unit-tests
Open

Enable windup's tests on Windows and MacOS#1671
mrizzi wants to merge 13 commits into
windup:masterfrom
mrizzi:run-multi-os-unit-tests

Conversation

@mrizzi

@mrizzi mrizzi commented May 24, 2023

Copy link
Copy Markdown
Member

The goal is to check issue https://issues.redhat.com/browse/WINDUP-3881 will happen when running ZipExportingTest on Windows.

Changes:

  • ReferenceResolvingVisitor.extractDefinitionLine method made 'new line marker' indipendent
  • JavaASTReferenceResolverTest: same test Java classes in java-ast/tests/src/test/resources have different sizes on different OSes
  • ExecutionStatisticsTest: replace Thread.sleep with busy wait because Linux and Windows have different interrupt perios (ref. https://stackoverflow.com/a/11498647)
  • Tests: refactored FileUtils.deleteDirectory in finally blocks to FileUtils.deleteQuietly due to issues with deletions on Windows (which would be worth being properly investigated rather than being workarounded)
  • Switch to shell: pwsh to consistently retrieve the CHROMEWEBDRIVER env variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants