Skip to content

merge latest from pterm/pterm#1

Closed
conradhanson wants to merge 301 commits into
solo-io:masterfrom
pterm:master
Closed

merge latest from pterm/pterm#1
conradhanson wants to merge 301 commits into
solo-io:masterfrom
pterm:master

Conversation

@conradhanson

Copy link
Copy Markdown

Description

The latest version of pterm/pterm has MultiPrinter struct that we use in the meshctl x validate resources command, but we can't use the latest pterm/pterm bc the race related PR that @josh-pritchard opened was never merged. These races show face when running meshctl e2e tests in CI.

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

MarvinJWendt and others added 30 commits April 2, 2023 02:15
…ns too many writers at once while testing.

Windows tests should be enough, because there is not much different and those things that are different, are tested in the specific packages anyway.
…max-value-it-returns-the-first-and-not-the-last-color
feat(logger): added pretty structured logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.