Use string 'true' for the 'exact' query parameter to retrieve users f…#7270
Open
akrist wants to merge 1 commit into
Open
Use string 'true' for the 'exact' query parameter to retrieve users f…#7270akrist wants to merge 1 commit into
akrist wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
Problem: The exact parameter value true in the Keycloak user query in keycloak_mbox_login_rest is converted to query parameter 1, which Keycloak interprets as “false”. Keycloak then performs a wildcard search (%$email%) and may return multiple users. This could allow a user to log in to another user’s account using their own password.
Solution:: Change exact parameter value from true (1) to 'true'.
Affected Containers
Did you run tests?
What did you tested?
IMAP logins using Keycloak users who have set a mailcow_password attribute.
What were the final results? (Awaited, got)
All users were able to log in using their own password.