integration_test/scenarios/mailbox/create_personal_folder_scenario.dart (1)

25-27: ⚡ Quick win

Consider selector specificity if multiple elements could match.

The selector $(name) matches elements by text content. If multiple UI elements contain the folder name (e.g., in breadcrumbs, headers, or duplicate mailbox entries), evaluate() might return multiple results, potentially matching unintended elements.

If selector specificity becomes an issue during testing, consider using a more specific selector:

// Example: constrain by widget type or ancestor
await waitForCondition(
  () async => $(MailboxListItem).$(name).evaluate().isNotEmpty,
);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@integration_test/scenarios/mailbox/create_personal_folder_scenario.dart`
around lines 25 - 27, The current waitForCondition uses the loose text selector
$(name).evaluate() which can match multiple UI elements (breadcrumbs, headers,
duplicates); change the selector to a more specific one (e.g., constrain by
widget type or ancestor) so you target the intended mailbox item—update the call
that uses waitForCondition and $(name).evaluate() to nest the selector under a
specific widget like MailboxListItem or another ancestor to ensure evaluate()
returns the intended element only.

integration_test/robots/mailbox_menu_robot.dart (1)

184-189: 💤 Low value

Consider using findsOneWidget for more precise mailbox verification.

The current implementation uses findsWidgets, which passes if one or more widgets match. For a mailbox name, you'd typically expect exactly one match. Using findsOneWidget would catch unexpected duplicates and provide more precise verification.

♻️ Optional refinement

 `@override`
 Future<void> expectMailboxWithNameVisible(String name) async {
   final mailboxItem = $(MailboxItemWidget).$(LabelMailboxItemWidget).$(name);
   await waitForCondition(() async => mailboxItem.evaluate().isNotEmpty);
-  expect(mailboxItem, findsWidgets);
+  expect(mailboxItem, findsOneWidget);
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@integration_test/robots/mailbox_menu_robot.dart` around lines 184 - 189, The
test uses findsWidgets which allows multiple matches; in
expectMailboxWithNameVisible change the assertion to expect exactly one match by
replacing expect(mailboxItem, findsWidgets) with expect(mailboxItem,
findsOneWidget) so the function expectMailboxWithNameVisible (and the
mailboxItem locator built from MailboxItemWidget -> LabelMailboxItemWidget ->
name) will fail on duplicates and ensure a single mailbox is visible.