TF-4449 [Part 2] Add drive_attachment presentation layer and composer integration#4588
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/4588. |
5aa39a2 to
549cfb6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
0e6d5b4 to
4e655ac
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
e8c6ec1 to
a58b282
Compare
29a5195 to
cf3c763
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
a58b282 to
21253a7
Compare
cf3c763 to
db33372
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
21253a7 to
50a7cb1
Compare
Add presentation layer to drive_attachment package: - Notifiers: DriveAttachmentNotifier, DriveAccessTokenNotifier, WorkplaceFqdnNotifier - Providers: DriveAttachmentProviders - Views: DriveIntentWebViewModal (mobile, web, shell variants) - Widgets: DriveAttachmentChip, DriveAttachmentListWidget, DriveAttachmentPickerButton - Mixins: DriveIntentMessageHandlerMixin, DriveIntentShims Integrate into main app: - Composer: attach drive files via picker button (mobile app bar, web bottom bar) - Service layer: ExternalAttachmentService, DriveExternalAttachmentAdapter - Network: inject drive access token in authorization interceptor - Bindings: register drive attachment providers in NetworkBindings - Bump jmap_dart_client to feature/linked-file-header
db33372 to
cb31307
Compare
There was a problem hiding this comment.
Gates Failed
(1 hotspot with Lines of Code in a Single File)
Our agent can fix these. Install it.
Gates Passed
Reason for failure
| Prevent hotspot decline | Violations | Code Health Impact | |
|---|---|---|---|
| app_localizations.dart | 1 rule in this hotspot | 8.55 → 8.03 | Suppress |
Absence of Expected Change Pattern
- tmail-flutter/lib/features/composer/presentation/widgets/mobile/app_bar_composer_widget.dart is usually changed with: tmail-flutter/lib/features/composer/presentation/widgets/mobile/landscape_app_bar_composer_widget.dart
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Issue
Description
Add presentation layer to drive_attachment package:
Integrate into main app:
Resolved
Web
web.mov
Mobile
mobile.webm