Skip to content

Evaluate all dependencies conjunctively #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlazingTwist wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Evaluate all dependencies conjunctively #1678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b22f557
Evaluate all dependencies conjunctively
BlazingTwist Nov 4, 2025
94bfd31
Update CHANGELOG.md
BlazingTwist Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
### Unreleased

- Fix multiple-dependencies with non-scalar values

### 2.15.2

- Support drag and drop for array item
Expand Down
10 changes: 5 additions & 5 deletions src/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,14 @@ export class AbstractEditor {
if (!editor || !editor.dependenciesFulfilled || !value) {
this.dependenciesFulfilled = false
} else if (Array.isArray(choices)) {
this.dependenciesFulfilled = choices.some(choice => {
this.dependenciesFulfilled &&= choices.some(choice => {
if (JSON.stringify(value) === JSON.stringify(choice)) {
return true
}
})
} else if (typeof choices === 'object') {
if (typeof value !== 'object') {
this.dependenciesFulfilled = choices === value
this.dependenciesFulfilled &&= choices === value
} else {
Object.keys(choices).some(key => {
if (!hasOwnProperty(choices, key)) {
Expand All @@ -199,12 +199,12 @@ export class AbstractEditor {
})
}
} else if (typeof choices === 'string' || typeof choices === 'number') {
this.dependenciesFulfilled = this.dependenciesFulfilled && value === choices
this.dependenciesFulfilled &&= value === choices
} else if (typeof choices === 'boolean') {
if (choices) {
this.dependenciesFulfilled = this.dependenciesFulfilled && (value || value.length > 0)
this.dependenciesFulfilled &&= (value || value.length > 0)
} else {
this.dependenciesFulfilled = this.dependenciesFulfilled && (!value || value.length === 0)
this.dependenciesFulfilled &&= (!value || value.length === 0)
}
}
}
Expand Down