Remove docker module dependency#1399
Open
pedro-a-n-moreira wants to merge 1 commit into
Open
Conversation
|
coverage: 52.375% (-2.1%) from 54.432% — pedro-a-n-moreira:codex/remove-docker-module-dep into golang-migrate:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This removes the root module dependency on
github.com/docker/dockerby moving the Docker test helper code to Moby's splitapiandclientmodules.It also replaces the external
github.com/dhui/dktesttest helper with an in-repo compatibility helper package backed by the same Moby split modules. Database integration tests now importgithub.com/golang-migrate/migrate/v4/dktest.Why
github.com/docker/dockercurrently pulls multiple Dependabot alerts into downstream projects that only import golang-migrate's runtime packages. Those projects do not use golang-migrate's Docker test helpers, but the dependency appears in the root module graph.Using Moby's split modules keeps the Docker-based test helper behavior available while removing the vulnerable monolithic Docker SDK module from consumers' dependency graphs.
Validation
go test ./dktest ./dktesting ./testinggo test ./database/... -run '^$'go list -m all | rg 'github.com/docker/docker|github.com/dhui/dktest'returns no matches