chore(deps): bump stylelint to 17.13.0 (#27702)#27703
Open
kheiner wants to merge 1 commit into
Open
Conversation
- bump stylelint from 16.26.1 to 17.13.0 - remove `-webkit-*` from `user-select`, `appearance`, and `mask-image` - change `px` to `rem` equivalent (related to directus#26826)
Contributor
Author
|
There's also the possibility of overriding the dependent package ( Line 59 in e522e02 I think the rest will still be required to fix if the lighter bump is preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
stylelintinpnpm-workspacefrom16.26.1to17.13.0stylelint@17.xships withcss-tree@3.2.1which resolves a peer dependency mismatch that caused an internal crash oncursor: pointer(Bad Syntax reference: )-webkit-user-select,-webkit-appearance,-webkit-mask-image) are not in the MDN spec so were removed.min-width,width) were updated to the recommended replacements (via--fix)pxtoremequivalent (related to Shrink app UI to 90% and convert all px to rem (16px browser default) #26826)Potential Risks / Drawbacks
stylelint@17.xis a major version bump, but reviewing their migration guide I think we're in the clear.Tested Scenarios
pnpm lint:stylepasses with zero violationsReview Notes / Questions
Note
Since this is dev only I didn't create a changeset file. I don't know if that's right or not, so feel free to tell me to add if necessary.
Checklist