http_client: don't panic on invalid block regex; use RwLock#7243
Open
nghiphaam wants to merge 1 commit into
Open
http_client: don't panic on invalid block regex; use RwLock#7243nghiphaam wants to merge 1 commit into
nghiphaam wants to merge 1 commit into
Conversation
Collaborator
|
Is this AI generated? Since the claim is invalid. The regex is checked during startup and config update, so this never fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should_block_address_regexcalledRegex::new(&block_regex).unwrap()on every miss. Config validation (config.rs) already rejects invalid patterns, but a slip-through (e.g. test path or a race) would crash the server mid-request. Swap theunwrap()for a logged warning + skip-block fallback.Also switched the cache from
MutextoRwLockso concurrent outbound HTTP checks don't serialise on the same lock when the regex is unchanged.