feat(oauth): generic oidc provider with deduplicated config#10615
Closed
shiva09-art wants to merge 2 commits into
Closed
feat(oauth): generic oidc provider with deduplicated config#10615shiva09-art wants to merge 2 commits into
shiva09-art wants to merge 2 commits into
Conversation
Contributor
|
This PR did not pass quality checks so it will be closed. If you believe this is a mistake please let us know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces generic OpenID Connect (OIDC) OAuth provider support. It allows the integration of any compliant OIDC provider without having to rely strictly on hardcoded, provider-specific configurations.
Changes Made:
kovah/laravel-socialite-oidcdependency (assumed as part of original PR feat(oauth): add generic oidc provider #6696).OidcExtendSocialitein the service provider.bootstrap/helpers/socialite.phpto initialize the OIDC driver.bootstrap/helpers/socialite.phpto deduplicate provider instantiations (authentik,clerk,zitadel, andoidc), resolving the code duplication issue highlighted by the CodeRabbit review.Bounty Reference
Claiming Bounty: This PR is an implementation of Pull Request/Issue #6696. The Open Bounties list showed a $20 bounty associated with this PR. I am referencing it here to claim or clarify the status of the bounty. Maintainers, please let me know if there's any further implementation needed!
How to Test